From: Mark Rutland <mark.rutland@arm.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools headers: Skip arm64 cputype.h check
Date: Mon, 16 Mar 2026 11:02:36 +0000 [thread overview]
Message-ID: <abfjTHwrHWaUiEY0@J2N7QTR9R3> (raw)
In-Reply-To: <20260316-tools_remove_sync_cputype-h-v1-1-9f0dc5931f09@arm.com>
On Mon, Mar 16, 2026 at 10:57:55AM +0000, Leo Yan wrote:
> Some definitions in the arm64 kernel's cputype.h are kernel specific and
> cause perf build failures when the header is synced into tools.
>
> Stop checking arm64's cputype.h. In the future, the header in tools
> will be updated manually as needed.
>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
I think it might be worth stating explicitly that we only need to update
this header when teaching the perf tool about new CPUs, but with or
without that wording:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> tools/perf/check-headers.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index da3aca87457fdc56c96d4184f2dee88dab026d98..31826621eebdb003d0fd681ae89822225dda966f 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -187,7 +187,6 @@ done
> check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" -I"^SYM_FUNC_START\(_LOCAL\)*(memcpy_\(erms\|orig\))" -I"^#include <linux/cfi_types.h>"'
> check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>" -I"^SYM_FUNC_START\(_LOCAL\)*(memset_\(erms\|orig\))"'
> check arch/x86/include/asm/amd/ibs.h '-I "^#include .*/msr-index.h"'
> -check arch/arm64/include/asm/cputype.h '-I "^#include [<\"]\(asm/\)*sysreg.h"'
> check include/linux/unaligned.h '-I "^#include <linux/unaligned/packed_struct.h>" -I "^#include <asm/byteorder.h>" -I "^#pragma GCC diagnostic"'
> check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common\(-tools\)*.h>"'
> check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"'
>
> ---
> base-commit: bb551508e78c886e6d3bcca6c744d3bc3fd8ad59
> change-id: 20260316-tools_remove_sync_cputype-h-2b0de59d5de5
>
> Best regards,
> --
> Leo Yan <leo.yan@arm.com>
>
prev parent reply other threads:[~2026-03-16 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 10:57 [PATCH] tools headers: Skip arm64 cputype.h check Leo Yan
2026-03-16 11:02 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfjTHwrHWaUiEY0@J2N7QTR9R3 \
--to=mark.rutland@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox