Re: [PATCH] perf intel-tpebs: Remove duplicate include of stat.h

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Mar 18, 2026 at 11:34:46AM -0700, Namhyung Kim wrote:
> On Wed, Mar 18, 2026 at 10:33:54AM -0700, Ian Rogers wrote:
> > On Tue, Mar 17, 2026 at 8:54 PM Chen Ni <nichen@iscas.ac.cn> wrote:
> > >
> > > Remove duplicate inclusion of stat.h in intel-tpebs.c to clean up
> > > redundant code.
> > >
> > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > 
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > 
> > We should really have a style for #includes and try to get it into the
> > kernel coding style. It doesn't matter so much in the kernel but
> > inconsistencies abound in tools, and the lack of alphabetical sorting
> > allows duplicates to occur. Here is a proposal that makes sense:
> > 
> > For any given C source file (e.g., server.c), group your #include
> > directives into distinct blocks separated by a blank line, ordered as
> > follows:
> >  * The Corresponding Header ("server.h")
> >  * C Standard Library Headers (<stdio.h>, <stdlib.h>)
> >  * OS/System-Specific Headers (<unistd.h>, <pthread.h>)
> >  * Third-Party Library Headers (<sqlite3.h>, <jansson.h>)
> >  * Your Project's Other Headers ("utils/logger.h", "database.h")
> > Within each block, alphabetize the headers.
> 
> Yep, sounds good.  I'm not sure if we want to convert all existing
> sources for this.  I think it's good for new changes touching header
> inclusion.

And then there are cases where there are ordering dependencies, which I
can't recall one to give as an example right now but I come accross in
the past.

So perhaps this should be made as a recommendation and when we have the
opportunity we change?

Just going thru lots of churn to have it look polished seems overkill
:-\

- Arnaldo
 
> Thanks,
> Namhyung