From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFFD3DF017; Mon, 30 Mar 2026 18:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774896553; cv=none; b=YzZFTyMSMxNs/hlv5mSmwuKJxlxtfnhwL7/Qz8uNsampHiHr3KaFjZL4YIzLJ9USm5jiUk9ZwtL2o4S6aiTTbcdctA9rbC5m5nq4k7wQh9NufvbDa/GcUSeo6khBz+a66dJwWZWLlJMpoB459yCpzDTSx173Mcquja1MWt9EAac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774896553; c=relaxed/simple; bh=8Nm/1L5pkcNmWQAXmMT+fbxFBk8UnQjXHBqgXHaaHgk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JvN7edvBOgWuUDpShVey5Ck6xjl+J/ubHlzNKobtr4TICSXOhk1+kvL9LgX0KDPSplXSM63xwFmcwA/+KKsPhAMHsqf3B6ftLQbkdlI5L2eKAb+A0mmYtwhYapVtrHpJXtLTPWC84Ngvi58npV5B01fUIzg7A830QesPdU7OcrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tyWJNud7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tyWJNud7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0C60C4CEF7; Mon, 30 Mar 2026 18:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774896552; bh=8Nm/1L5pkcNmWQAXmMT+fbxFBk8UnQjXHBqgXHaaHgk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tyWJNud7VTB0Kze7DFHOX6R1mGabF5cICm9Wqxrz7xdeh6RWsSepDjX70jfbiprIW FirODeC5ftC0ly5hvgFC5ddpc1Ikv+m+gHd0g/u376HR7zVDiSZ3e3E/ob61YCSTfE B4Y04uuiAS9kdYUKHydxzvjuJ4hMaVAG8M9YHOI0IhxY3vR0Z03vkAPD//3+NtX+9Y irudrODOVYvyy1PZmVFR9dJPzr8/gLmhdYkmhV2wyKKNJbK/bn//f0W9waEK5sMbRl AFDnXYTItUorwOwaHG9MFib1ROV3arzXFmYUlraOcscwlNdLOMpvJJrw5Dpa51dHiD hTyw3hJ1zid/g== Date: Mon, 30 Mar 2026 15:49:09 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , 9erthalion6@gmail.com, adrian.hunter@intel.com, alex@ghiti.fr, alexander.shishkin@linux.intel.com, andrew.jones@oss.qualcomm.com, aou@eecs.berkeley.edu, atrajeev@linux.ibm.com, blakejones@google.com, ctshao@google.com, dapeng1.mi@linux.intel.com, howardchu95@gmail.com, james.clark@linaro.org, john.g.garry@oracle.com, jolsa@kernel.org, leo.yan@linux.dev, libunwind-devel@nongnu.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, mingo@redhat.com, palmer@dabbelt.com, peterz@infradead.org, pjw@kernel.org, shimin.guo@skydio.com, tglozar@redhat.com, tmricht@linux.ibm.com, will@kernel.org, amadio@gentoo.org, yuzhuo@google.com Subject: Re: [PATCH v1 0/2] perf build: Remove libunwind support Message-ID: References: <20260321234220.848859-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 27, 2026 at 06:08:27PM -0300, Arnaldo Carvalho de Melo wrote: > On Fri, Mar 27, 2026 at 01:37:20PM -0700, Ian Rogers wrote: > > On Fri, Mar 27, 2026 at 1:07 PM Arnaldo Carvalho de Melo wrote: > > > This is an area that is tricky and since we _already_ have two > > > implementations, the good thing for regression testing would be the > > > compare their results until libunwind becomes completely rotten and > > > unusable? > > > > My series: > > https://lore.kernel.org/lkml/20260305221927.3237145-1-irogers@google.com/ > > makes libdw and libunwind supported together: > > https://lore.kernel.org/lkml/20260305221927.3237145-2-irogers@google.com/ > > """ > > This commit refactors the DWARF unwind post-processing to be > > configurable at runtime via the .perfconfig file option > > 'unwind.style', or using the argument '--unwind-style' in the commands > > 'perf report', 'perf script' and 'perf inject', in a similar manner to > > the addr2line or the disassembler style. > > """ > > That series cleans up several other issues, which is why I think it is > > worth landing while we wait for libdw to become stable. > > Cool, I'll try and review/test it this weekend. > > Thanks for pointint it out! Pointing, looking at it now, one comment so far, remove that new blank line, testing... ⬢ [acme@toolbx perf-tools-next]$ git am ./v2_20260305_irogers_perf_libunwind_multiple_remote_support.mbx Applying: perf unwind: Refactor get_entries to allow dynamic libdw/libunwind selection .git/rebase-apply/patch:128: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: perf build loongarch: Remove reference to missing file Applying: tools build: Deduplicate test-libunwind for different architectures Applying: perf build: Be more programmatic when setting up libunwind variables Applying: perf unwind-libunwind: Make libunwind register reading cross platform Applying: perf unwind-libunwind: Move flush/finish access out of local Applying: perf unwind-libunwind: Remove libunwind-local Applying: perf unwind-libunwind: Add RISC-V libunwind support ⬢ [acme@toolbx perf-tools-next]$