From: Agustin Vega-Frias <agustinv@codeaurora.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
timur@codeaurora.org
Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Thu, 08 Mar 2018 08:28:13 -0500 [thread overview]
Message-ID: <ae102272a8186f0351363511f4ed07f8@codeaurora.org> (raw)
In-Reply-To: <20180308130358.GC3701@kernel.org>
On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
>> +++ b/tools/perf/util/parse-events.y
>> @@ -8,6 +8,7 @@
>>
>> #define YYDEBUG 1
>>
>> +#include <fnmatch.h>
>> #include <linux/compiler.h>
>> #include <linux/list.h>
>> #include <linux/types.h>
>> @@ -234,6 +235,10 @@ PE_NAME opt_event_config
>> if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
>> struct perf_pmu *pmu = NULL;
>> int ok = 0;
>> + char *pattern;
>> +
>> + if (asprintf(&pattern, "%s*", $1) < 0)
>> + YYABORT;
>
> + if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)
>
> I completely overlook that you were using this and thus needed that
> extension, duh, thanks for the patience 8-) and for the new patch.
>
NP Arnaldo, thanks for the quick turnaround on these patches :o)
Just so I know, since these are my first patches on perf tools,
where are perf tools patches queued once acked?
Thanks!
--
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a
Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-03-08 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 20:35 [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events Agustin Vega-Frias
2018-03-08 13:03 ` Arnaldo Carvalho de Melo
2018-03-08 13:28 ` Agustin Vega-Frias [this message]
2018-03-08 13:39 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae102272a8186f0351363511f4ed07f8@codeaurora.org \
--to=agustinv@codeaurora.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).