Linux Perf Users
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Chun-Tse Shao <ctshao@google.com>
Cc: sashiko-reviews@lists.linux.dev, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf stat: Fix uncore metric scaling bug across sockets and nodes
Date: Tue, 19 May 2026 17:56:27 -0700	[thread overview]
Message-ID: <ag0Gu1v9KOJPmaVF@google.com> (raw)
In-Reply-To: <CAJpZYjXh2DFpnS3+_cKhJ==6n31qBU8Cnks9VXZB_qH5i7S-eQ@mail.gmail.com>

Hi CT,

On Tue, May 19, 2026 at 11:06:40AM -0700, Chun-Tse Shao wrote:
> Based on the AI review, instead of changing `source_count` behavior, I
> will expose `aggr->nr` in perf python metrics and fix per-aggregation
> metrics accordingly.

Please don't top post.

https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying

Thanks,
Namhyung

> 
> On Mon, May 18, 2026 at 4:44 PM <sashiko-bot@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Medium] The patch codifies a mathematical scaling error across all aggregation modes for uncore metrics by changing `source_count` to `aggr->nr` without removing `#num_packages` from the JSON formulas.
> > --

      reply	other threads:[~2026-05-20  0:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 23:11 [PATCH] perf stat: Fix uncore metric scaling bug across sockets and nodes Chun-Tse Shao
2026-05-18 23:44 ` sashiko-bot
2026-05-19 18:06   ` Chun-Tse Shao
2026-05-20  0:56     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag0Gu1v9KOJPmaVF@google.com \
    --to=namhyung@kernel.org \
    --cc=ctshao@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox