From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: namhyung@kernel.org, akpm@linux-foundation.org, joe@perches.com,
justinstitt@google.com, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, morbo@google.com, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf clang-format: Add a perf clang-format that overrides some kernel behaviors
Date: Wed, 20 May 2026 15:38:57 -0300 [thread overview]
Message-ID: <ag3_wYuUbKi1al3s@x1> (raw)
In-Reply-To: <CAP-5=fU9m_kHV+qKogUQhZhtguhCoxKsC051APsyQW5zjzbZFQ@mail.gmail.com>
On Wed, May 20, 2026 at 08:37:24AM -0700, Ian Rogers wrote:
> On Mon, Apr 27, 2026 at 11:54 PM Ian Rogers <irogers@google.com> wrote:
> >
> > In particular, header file ordering is an issue in the tools/perf
> > directory given the larger number of depended upon libraries.
> >
> > The order of header file includes was proposed in:
> > https://lore.kernel.org/linux-perf-users/CAP-5=fUitzKwJONTngiW17XkS7kVr2cDS4cDL_HccJKcnR2EgQ@mail.gmail.com/
> >
> > Sorting headers is desirable to avoid issues like duplicate includes.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > v2: Move the .clang-format file under tools/perf rather than tools/.
>
> This change helps format header files in tools/perf, otherwise
> following the parent linux clang-format options. Could we land this in
> perf-tools-next?
Thanks, applied to perf-tools-next, for v7.2.
- Arnaldo
prev parent reply other threads:[~2026-05-20 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260407165551.3075684-1-irogers@google.com>
2026-04-28 6:54 ` [PATCH v2] perf clang-format: Add a perf clang-format that overrides some kernel behaviors Ian Rogers
2026-05-20 15:37 ` Ian Rogers
2026-05-20 18:38 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag3_wYuUbKi1al3s@x1 \
--to=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=irogers@google.com \
--cc=joe@perches.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox