From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773852EF653 for ; Thu, 21 May 2026 14:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373082; cv=none; b=XSBh0aM1LMAusk4dXLpQZEH++YEbUAYFHEHCFmJa23QXtTtLbAnJO2QouFCYE2+geebvctC6i75KACRFn7foBp75ymEVrWnXeMmsyf18+7EeatumAeY0T5bVlVa+3VNFuM4Swz7Uh26bPELGb2HoiVL0NONacYFcDRGl0LNwzpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373082; c=relaxed/simple; bh=J3oAsPwZR2QbHty4A0QeSooUfi8YB3kVpxm16huHj14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EhX7C/YFrlo6JkdFWIVVm/K9tanE6Y7BYEkVzpPTYjJWGcci5ND3hr87TWDKyUW5IKPKgnDQILM9bycTxwHlbLnQfCuYVxaoFjxYYQM5BbT2fL0sCiOFuf2XzcQTNIxOIFJZncWjmIHh2PFC543mP1FDUeCOcLlSPrc0l9EiEqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AEw4Oz5F; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AEw4Oz5F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C30191F000E9; Thu, 21 May 2026 14:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779373081; bh=CU7Jj/X6QYmcmszy64Ym5CLJFYdXggn2LGX/XrIXs6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AEw4Oz5FwLp5Q4ZQCje3wIdhbs4n701tJg1D6NntHxCY1enISj0o/kIYTYiycJHBK n0y2N9/nYiQWGEDW6eCtizXtfL0z9Z4nPhMR1FEvyJR6+b7Al+8DTBrzzqwJO2RX65 4kAqp0NHgZPVGYXaV+KAdFAlhWJfD9T21T+KAGyPBCWtzcSRSYGw7H5Pz37Xl4h2HM 1YsrjrK2Br8MBQJyr+Bca4TJOp6VBsgzaCYT/Y07XxzoGiN/StSuaow94UZ7gzHvsn 0CknFojpO0wbLHIINZoQvZHT7YZSrHA4ygG2W/LL5iEB5aoVjQ+xl1PAXLnsjD2b7W ZSBYHUCqJf8Vg== Date: Thu, 21 May 2026 11:17:58 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev Cc: Namhyung Kim , Ian Rogers , jolsa@kernel.org, adrian.hunter@intel.com, mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, hbathini@linux.vnet.ibm.com, Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, Shivani.Nittor@ibm.com Subject: Re: [PATCH] tools/perf/sched: Update process names of processes in zombie state for both -s and -S options Message-ID: References: <20260426093930.47809-1-atrajeev@linux.ibm.com> <230801A2-5F9C-42A6-9390-B44786309E30@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <230801A2-5F9C-42A6-9390-B44786309E30@linux.ibm.com> On Thu, May 21, 2026 at 02:02:53PM +0530, Athira Rajeev wrote: > > On 27 Apr 2026, at 11:26 AM, Namhyung Kim wrote: > > On Sun, Apr 26, 2026 at 03:09:30PM +0530, Athira Rajeev wrote: > >> In redhat perftool testsuite, observed fail for this test: > >> -- [ FAIL ] -- perf_sched :: test_timehist :: --with-summary (output regexp parsing) > >> > >> This led to analysis of "perf sched timehist" summary options. > >> > >> # perf sched record -a -o ./perf.data -- sleep 0.1 > >> This will record using perf sched record > >> > >> perf sched timeliest has two options "-s" and "-S" > >> # perf sched -i ./perf.data timehist -S > >> -S : Captures summary also at the end > >> > >> # perf sched -i ./perf.data timehist -s > >> -s : Captures only summary > >> > >> The test saves -s result which has only summary and compares with > >> summary which comes at the end from -S . Since there is a difference > >> in these two, test fails. > >> > >> Checking the behaviour change in -S and -s results, difference is: > >> > >> rcu_sched[16] 2 4 0.013 0.001 0.003 0.006 33.23 0 > >> migration/11[73] 2 1 0.006 0.006 0.006 0.006 0.00 0 > >> migration/3[33] 2 1 0.006 0.006 0.006 0.006 0.00 0 > >> - :216753[216753] -1 1 0.041 0.041 0.041 0.041 0.00 0 > >> + sleep[216753] -1 1 0.041 0.041 0.041 0.041 0.00 0 > >> migration/8[58] 2 1 0.005 0.005 0.005 0.005 0.00 0 > >> NetworkManager[811] 1 2 0.089 0.028 0.044 0.060 36.06 0 > >> migration/13[83] 2 1 0.005 0.005 0.005 0.005 0.00 0 > >> > >> Here 216753 is pid for sleep which is a zombie process. This is > >> happening in latest kernel due to an update in "-S" result. > >> In -S, the process name appears in the results "sleep[216753]", > >> where as in the -s, only pid is present in the summary result > >> ":216753[216753]". > >> > >> After commit 39f473f6d0b2 ("perf sched timehist: decode process names > >> of processes in zombie state") > >> for -S option, if process name is using pid, it uses different way to > >> set it. So that we get the process name and not just Pid. > >> > >> This change went in only for timehist_print_sample() function. > >> Add this improvement in generic place so that even -s option (which > >> captures summary) also will have meaningful information. > >> > >> Signed-off-by: Athira Rajeev > > > > Acked-by: Namhyung Kim > > > > Thanks, > > Namhyung > Hi, > > Can we please have this pulled in, if the patch looks fine ? Can you please check applying it on top of current perf-tools-next? Thanks, - Arnaldo