From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf stat: Make metric only column line up with header
Date: Fri, 22 May 2026 17:25:34 -0300 [thread overview]
Message-ID: <ahC7vhJiLN6C8EQx@x1> (raw)
In-Reply-To: <CAP-5=fXhi9W-T1BLJVvQ4DRN6EpxtZQduev0fVXNJTmrF6idSw@mail.gmail.com>
On Wed, May 13, 2026 at 09:23:38AM -0700, Ian Rogers wrote:
> On Wed, May 13, 2026 at 7:55 AM Andi Kleen <ak@linux.intel.com> wrote:
> > Before:
> > % perf stat --topdown -a -I 1000
> > + time % tma_backend_bound % tma_frontend_bound % tma_bad_speculation % tma_retiring
> > 1.000190386 45.5 40.0 5.3 9.2
> > 2.005185654 45.3 40.1 5.6 9.0
> > 3.009193207 45.4 39.9 5.6 9.1
> > After:
> > % perf stat --topdown -a -I 1000
> > + time % tma_backend_bound % tma_frontend_bound % tma_bad_speculation % tma_retiring
> > 1.000810024 46.3 39.7 5.3 8.7
> > 2.004800656 45.8 39.8 5.4 8.9
> > 3.008804783 46.0 39.6 5.4 9.0
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next, for v7.2.
> I dislike the spaghetti code in stat-display.c :-) One day it would be
> great to throw an LLM at doing a clean implementation. Having tests
> for formatting would be useful :-)
:-)
- Arnaldo
next prev parent reply other threads:[~2026-05-22 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 14:49 [PATCH v2] perf stat: Make metric only column line up with header Andi Kleen
2026-05-13 16:23 ` Ian Rogers
2026-05-22 20:25 ` Arnaldo Carvalho de Melo [this message]
2026-05-14 6:10 ` sashiko-bot
2026-05-22 15:45 ` [PING] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahC7vhJiLN6C8EQx@x1 \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox