Re: [PATCH 1/3] perf trace: Include copied headers in the beauty directory

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, May 25, 2026 at 01:31:29AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The copied UAPI header `fcntl.h` includes `<linux/openat2.h>`, which was not copied into the `tools/include/uapi/linux/` directory, causing build failures on older host systems.
> --
> 
> commit 7bb011deeef80e2496028a3477432fac108a240f
> Author: Namhyung Kim <namhyung@kernel.org>
> 
> perf trace: Include copied headers in the beauty directory
> 
> This commit updates the trace beauty scripts to use local copies of UAPI 
> kernel headers directly, rather than relying on system headers or manual 
> macro definitions.
> 
> > diff --git a/tools/perf/trace/beauty/fcntl.c b/tools/perf/trace/beauty/fcntl.c
> > index e1b99b8f55eb0..10fd6a2b75c35 100644
> > --- a/tools/perf/trace/beauty/fcntl.c
> > +++ b/tools/perf/trace/beauty/fcntl.c
> [ ... ]
> > -#include "trace/beauty/beauty.h"
> >  #include <linux/kernel.h>
> > -#include <linux/fcntl.h>
> [ ... ]
> > +#include "trace/beauty/beauty.h"
> > +#include "trace/beauty/include/uapi/linux/fcntl.h"
> 
> [Severity: Low]
> Will this cause a build failure on systems with older kernel headers?
> 
> The newly copied uapi/linux/fcntl.h includes <linux/openat2.h>, but it 
> appears openat2.h was not copied into the tools directory. On build 
> environments with kernel headers older than v5.6, the compiler will fall 
> back to the host system's include paths, fail to find linux/openat2.h, 
> and halt the build.
> 
> Should linux/openat2.h also be copied into the tools include directory to
> prevent this?

So, this is exactly the kind of dependencies I mentioned in my reply to
you :-)

- Arnaldo