From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C555036AF6; Tue, 26 May 2026 00:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779755693; cv=none; b=RjUi/nsNZbqskzilj0o4TeZrcN9kkZOQwBSm31XdIrzBz0bglkfyX991ZOcUXrOLfXP+3Vvop/xdwKVgEDANgKXoftb14GuThEvP4qDzxVsN2SXLRmTMdphgGCvd5N0TGIu9nSXD1NgEe7xpZxYJZTWEZelTSHNhz2MxyYwjir8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779755693; c=relaxed/simple; bh=g/1LzyCVk8CBxbfY42s1YmXmAR55qCU/UEsbQZtmzag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y69tpoLW379Ixt9eniTahhWZihS3No/21J0UZq+iuQY1cZORPHkps4D+083H4FGcTaZt2v6a+oNZxyKkIGqg/kkgCe5/Ro9O9aakWTFiqHtFeOSDfbZYXZOJl+hCrrUyUJNWdaLV7D1mJ+0N5TwBLgs3Q7HMuSkikShKK96Y/qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eDLZ2QuY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eDLZ2QuY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39DBD1F000E9; Tue, 26 May 2026 00:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779755692; bh=1OJa2o21mkJ9h69pPE4pTV9VioWjPVfkljpsjc3LcvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=eDLZ2QuY1GoKhRyM6IjiClv3ZyY0EMoVt21gXfq9E3WVXtU8knE4PWR8m1igIPPP7 CPIML+UmRymIqAtBmDeqkSQk0XYsAOrpTij6YcYZwyNCx9onUXml2JD6AE4p9cKums H+qcypgU1TdpXh1N1jl+SkiocOR5YAoKkezPJjDrQlo8cMxQfYyzQfiBQAkx2VIuyd /8+S8mFyRa+3fD5e0ZWdHcLYwfsaan8+P1bc9Eq/SI4omykzv8qPDy1xJrQ03CXp7Y YEROQG70ZPplgnS6Y7MgKbMzldomE+iSCHzAj63KdV0+cxnBQD364S/sRU6Mfgdby/ l+xDVBMFdLfsQ== Date: Mon, 25 May 2026 19:34:48 -0500 From: Namhyung Kim To: Ian Rogers Cc: acme@kernel.org, adrian.hunter@intel.com, alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, james.clark@linaro.org, leo.yan@linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, tmricht@linux.ibm.com Subject: Re: [PATCH v9 02/23] perf arch x86: Sort includes and add missed explicit dependencies Message-ID: References: <20260428071903.1886173-1-irogers@google.com> <20260522220435.2378363-1-irogers@google.com> <20260522220435.2378363-3-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260522220435.2378363-3-irogers@google.com> On Fri, May 22, 2026 at 03:04:13PM -0700, Ian Rogers wrote: > Fix missing #includes found while cleaning the evsel/evlist header > files. Sort the remaining header files for consistency with the rest > of the code. > > Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/arch/x86/util/intel-bts.c | 20 +++++++++++-------- > tools/perf/arch/x86/util/intel-pt.c | 29 +++++++++++++++------------- > 2 files changed, 28 insertions(+), 21 deletions(-) > > diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c > index 85c8186300c8..100a23d27998 100644 > --- a/tools/perf/arch/x86/util/intel-bts.c > +++ b/tools/perf/arch/x86/util/intel-bts.c > @@ -4,26 +4,30 @@ > * Copyright (c) 2013-2015, Intel Corporation. > */ > > +#include "../../../util/intel-bts.h" > + > #include > -#include > -#include > + > #include > +#include > #include > +#include > #include > > +#include // page_size > + > +#include "../../../util/auxtrace.h" > #include "../../../util/cpumap.h" > +#include "../../../util/debug.h" > #include "../../../util/event.h" > -#include "../../../util/evsel.h" > #include "../../../util/evlist.h" > +#include "../../../util/evsel.h" > #include "../../../util/mmap.h" > -#include "../../../util/session.h" > +#include "../../../util/pmu.h" > #include "../../../util/pmus.h" > -#include "../../../util/debug.h" > #include "../../../util/record.h" > +#include "../../../util/session.h" > #include "../../../util/tsc.h" > -#include "../../../util/auxtrace.h" > -#include "../../../util/intel-bts.h" > -#include // page_size > > #define KiB(x) ((x) * 1024) > #define MiB(x) ((x) * 1024 * 1024) > diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c > index c131a727774f..0307ff15d9fc 100644 > --- a/tools/perf/arch/x86/util/intel-pt.c > +++ b/tools/perf/arch/x86/util/intel-pt.c > @@ -3,36 +3,39 @@ > * intel_pt.c: Intel Processor Trace support > * Copyright (c) 2013-2015, Intel Corporation. > */ > +#include "../../../util/intel-pt.h" > > #include > #include > -#include > -#include > + > #include > +#include > +#include > #include > +#include > #include > -#include > > -#include "../../../util/session.h" > +#include > +#include // page_size > +#include > + > +#include "../../../util/auxtrace.h" > +#include "../../../util/config.h" > +#include "../../../util/cpumap.h" > +#include "../../../util/debug.h" > #include "../../../util/event.h" > #include "../../../util/evlist.h" > #include "../../../util/evsel.h" > #include "../../../util/evsel_config.h" > -#include "../../../util/config.h" > -#include "../../../util/cpumap.h" > #include "../../../util/mmap.h" > -#include > #include "../../../util/parse-events.h" > -#include "../../../util/pmus.h" > -#include "../../../util/debug.h" > -#include "../../../util/auxtrace.h" > #include "../../../util/perf_api_probe.h" > +#include "../../../util/pmu.h" > +#include "../../../util/pmus.h" > #include "../../../util/record.h" > +#include "../../../util/session.h" > #include "../../../util/target.h" > #include "../../../util/tsc.h" > -#include // page_size > -#include "../../../util/intel-pt.h" > -#include > #include "cpuid.h" > > #define KiB(x) ((x) * 1024) > -- > 2.54.0.794.g4f17f83d09-goog >