Linux Perf Users
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Tanushree Shah <tshah@linux.ibm.com>,
	jolsa@kernel.org, adrian.hunter@intel.com, vmolnaro@redhat.com,
	mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,
	namhyung@kernel.org, linux-perf-users@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, atrajeev@linux.ibm.com,
	hbathini@linux.ibm.com, Tejas.Manhas1@ibm.com,
	Tanushree.Shah@ibm.com, Shivani.Nittor@ibm.com
Subject: Re: [PATCH] perf data convert json: Fix addr_location leak on time-filtered samples
Date: Wed, 10 Jun 2026 17:06:23 -0300	[thread overview]
Message-ID: <ainDvxug5fvibbbR@x1> (raw)
In-Reply-To: <CAP-5=fUOUtbfXXtGdSYrg1SfuTryNqFPknKWDc=4MxK==m6+VQ@mail.gmail.com>

On Sat, Jun 06, 2026 at 08:47:37AM -0700, Ian Rogers wrote:
> On Sat, Jun 6, 2026 at 5:20 AM Tanushree Shah <tshah@linux.ibm.com> wrote:
> >
> > When samples are skipped due to time filtering in process_sample_event(),
> > the early return path bypasses addr_location__exit(), causing memory leaks
> > of thread, map, and maps references acquired by machine__resolve().
> >
> > These references must be released through addr_location__exit() before
> > returning.
> >
> > Fixes: 8e746e95c3e4 ("perf data: Allow filtering conversion by time range")
> > Signed-off-by: Tanushree Shah <tshah@linux.ibm.com>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next, for v7.2.

- Arnaldo

      reply	other threads:[~2026-06-10 20:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-06 12:15 [PATCH] perf data convert json: Fix addr_location leak on time-filtered samples Tanushree Shah
2026-06-06 15:47 ` Ian Rogers
2026-06-10 20:06   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ainDvxug5fvibbbR@x1 \
    --to=acme@kernel.org \
    --cc=Shivani.Nittor@ibm.com \
    --cc=Tanushree.Shah@ibm.com \
    --cc=Tejas.Manhas1@ibm.com \
    --cc=adrian.hunter@intel.com \
    --cc=atrajeev@linux.ibm.com \
    --cc=hbathini@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=tmricht@linux.ibm.com \
    --cc=tshah@linux.ibm.com \
    --cc=vmolnaro@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox