Linux Perf Users
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>, Leo Yan <leo.yan@arm.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test: Compile named_threads workload with -O0
Date: Thu, 11 Jun 2026 12:08:58 -0300	[thread overview]
Message-ID: <airPimFmTCute2PT@x1> (raw)
In-Reply-To: <20260611-james-cs-unformatted-per-thread-fix-followup-v1-1-3c855d93dba8@linaro.org>

On Thu, Jun 11, 2026 at 12:13:46PM +0100, James Clark wrote:
> The work loop relies on the compiler not optimizing it away, although
> named_threads_work is not static for that reason, the compiler could
> still do it.
> 
> Fix it by compiling without optimization. Also add -fno-inline for
> consistency and in case anyone wants to look at callstacks.
> 
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> One trailing Sashiko fix from the "perf cs-etm: Queue context packets
> for frontend" patch series that has been applied already.

I'll add a Fixes tag pointing to that cset, also a reported-by sashiko
and a closes, for completeness.

Thanks, applying.

- Arnaldo

> ---
>  tools/perf/tests/workloads/Build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/workloads/Build b/tools/perf/tests/workloads/Build
> index 75b377934a0e..7bb4b9829ba2 100644
> --- a/tools/perf/tests/workloads/Build
> +++ b/tools/perf/tests/workloads/Build
> @@ -26,3 +26,4 @@ CFLAGS_datasym.o          = -g -O0 -fno-inline -U_FORTIFY_SOURCE
>  CFLAGS_traploop.o         = -g -O0 -fno-inline -U_FORTIFY_SOURCE
>  CFLAGS_inlineloop.o       = -g -O2
>  CFLAGS_deterministic.o    = -g -O0 -fno-inline -U_FORTIFY_SOURCE
> +CFLAGS_named_threads.o    = -g -O0 -fno-inline -U_FORTIFY_SOURCE
> 
> ---
> base-commit: 7336514f41e75d44782fee7e0990d4195a3d3161
> change-id: 20260611-james-cs-unformatted-per-thread-fix-followup-babf28a4e640
> 
> Best regards,
> -- 
> James Clark <james.clark@linaro.org>

  parent reply	other threads:[~2026-06-11 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 11:13 [PATCH] perf test: Compile named_threads workload with -O0 James Clark
2026-06-11 12:38 ` Leo Yan
2026-06-11 15:08 ` Arnaldo Carvalho de Melo [this message]
2026-06-11 15:11   ` James Clark
2026-06-11 18:54 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=airPimFmTCute2PT@x1 \
    --to=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox