Re: [PATCH] perf build: Add LDFLAGS to dlfilters .so link

[Namhyung Kim <namhyung@kernel.org>]

On Fri, Jun 26, 2026 at 06:34:23PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Adding `$(LDFLAGS)` to the unconditionally built `dlfilters` shared library link rule breaks statically linked `perf` builds.
> --
> 
> commit 18f2c24db710920618ef1d894a2b24abff4dbeb9
> Author: Trevor Allison <tallison@redhat.com>
> 
> perf build: Add LDFLAGS to dlfilters .so link
>     
> Build-time linker flags were not applied when linking dlfilters.
> Pass LDFLAGS for consistency with the other link rules.
> 
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 476b8dcaef58c..f2294a6d89604 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -677,7 +677,7 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
> >  .SECONDARY: $(DLFILTERS:.so=.o)
> >  
> >  $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
> > -	$(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
> > +	$(QUIET_LINK)$(CC) $(LDFLAGS) $(EXTRA_CFLAGS) -shared -o $@ $<
> 
> [Severity: Low]
> Does this break static builds of perf?
> 
> If a user builds perf statically by setting LDFLAGS="-static", this rule
> will pass both "-static" and "-shared" to the linker. Since these flags are
> mutually exclusive, this results in a fatal linker error.

Oops, I missed this message and merged it.  It indeed caused a failure 
in the build test.  It seems we should skip building dlfilters when the
LDFLAGS has -static or remove -static from the LDFLAGS for dlfilters.

Thanks,
Namhyung