Re: [PATCH 1/9] perf test: Adding an entry for the perftool-testsuite

[Michael Petlan <mpetlan@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]

On Sun, 27 Mar 2016, Jiri Olsa wrote:
>
> got following compile error:
>
>  CC       tests/suite.o
> tests/suite.c: In function ‘test__suite’:
> tests/suite.c:119:20: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
>  _tempdir_template = mkdtemp(tempdir_template);
>                    ^
> tests/suite.c:120:30: error: passing argument 2 of ‘setenv’ makes pointer from integer without a cast [-Werror=int-conversion]
>  setenv("PERFSUITE_RUN_DIR", _tempdir_template, 1);
>                              ^
> In file included from tests/suite.h:6:0,
>                 from tests/suite.c:1:
> /usr/include/stdlib.h:584:12: note: expected ‘const char *’ but argument is of type ‘char’
> extern int setenv (const char *__name, const char *__value, int __replace)
>            ^
> cc1: all warnings being treated as errors
>
>
> moving on with attached patch

I noticed this error too and that's why I sent the mail with the following $subj:
"[PATCH 1/9] perf test: Adding an entry for the perftool-testsuite - CORRECT"

A stupid mistake, of course it must be a pointer.

Michael

>
> thanks,
> jirka
>
>
> ---
> diff --git a/tools/perf/tests/suite.c b/tools/perf/tests/suite.c
> index 17f66107f34d..1561bec3a2e1 100644
> --- a/tools/perf/tests/suite.c
> +++ b/tools/perf/tests/suite.c
> @@ -108,7 +108,8 @@ int test__suite(int subtest __maybe_unused)
> 	int test_status = TEST_OK;
> 	char verbosity_str[2];
> 	int _verbose = (verbose > 9)? 9 : verbose;
> -	char tempdir_template[24], _tempdir_template;
> +	char tempdir_template[24];
> +	char *_tempdir_template;
>
> 	/* set verbosity according to perf-test command line switches */
> 	snprintf(verbosity_str, 2, "%i", _verbose);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>