From: Michael Petlan <mpetlan@redhat.com>
To: acme@redhat.com
Cc: linux-perf-users@vger.kernel.org, jolsa@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] perf scripts python: fix passing arguments to stackcollapse report
Date: Mon, 6 Sep 2021 16:16:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.LRH.2.20.2109061615390.27231@Diego> (raw)
In-Reply-To: <20200427142327.21172-1-mpetlan@redhat.com>
Hi Arnaldo, could you merge this?
It seems still valid.
Thank you.
Michael
On Mon, 27 Apr 2020, Michael Petlan wrote:
> The '--' prevented arguments from being passed to the script, such as:
>
> $ perf script report stackcollapse -i my_perf.data
>
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
> tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/scripts/python/bin/stackcollapse-report b/tools/perf/scripts/python/bin/stackcollapse-report
> index 356b9656393d..21a356bd27f6 100755
> --- a/tools/perf/scripts/python/bin/stackcollapse-report
> +++ b/tools/perf/scripts/python/bin/stackcollapse-report
> @@ -1,3 +1,3 @@
> #!/bin/sh
> # description: produce callgraphs in short form for scripting use
> -perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
> +perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
> --
> 2.18.1
>
>
next parent reply other threads:[~2021-09-06 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427142327.21172-1-mpetlan@redhat.com>
2021-09-06 14:16 ` Michael Petlan [this message]
2021-09-09 12:43 ` [PATCH] perf scripts python: fix passing arguments to stackcollapse report Arnaldo Carvalho de Melo
2021-09-09 12:44 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.2109061615390.27231@Diego \
--to=mpetlan@redhat.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).