linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Petlan <mpetlan@redhat.com>
To: acme@redhat.com
Cc: linux-perf-users@vger.kernel.org, jolsa@redhat.com,
	sumanthk@linux.ibm.com
Subject: Re: [PATCH] perf test: Fix bpf test sample mismatch reporting
Date: Mon, 6 Sep 2021 16:26:31 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LRH.2.20.2109061625540.27231@Diego> (raw)
In-Reply-To: <20210805160611.5542-1-mpetlan@redhat.com>

Hi Arnaldo, please have a look.
This is still valid.
Thanks.
Michael

On Thu, 5 Aug 2021, Michael Petlan wrote:
> When the expected sample count in the condition changed, the message
> needs to be changed too, otherwise we'll get:
> 
>   0x1001f2091d8: mmap mask[0]:
>   BPF filter result incorrect, expected 56, got 56 samples
> 
> Fixes: 4b04e0decd25 ("perf test: Fix basic bpf filtering test")
> 
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
>  tools/perf/tests/bpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
> index dbf5f5215abe..fa03ff0dc083 100644
> --- a/tools/perf/tests/bpf.c
> +++ b/tools/perf/tests/bpf.c
> @@ -192,7 +192,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
>  	}
>  
>  	if (count != expect * evlist->core.nr_entries) {
> -		pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
> +		pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect * evlist->core.nr_entries, count);
>  		goto out_delete_evlist;
>  	}
>  
> -- 
> 2.18.4
> 
> 


  reply	other threads:[~2021-09-06 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 16:06 [PATCH] perf test: Fix bpf test sample mismatch reporting Michael Petlan
2021-09-06 14:26 ` Michael Petlan [this message]
2021-09-09 12:42   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.20.2109061625540.27231@Diego \
    --to=mpetlan@redhat.com \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sumanthk@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).