Re: [PATCH 1/7] perf testsuite: Add common regex patters

[Michael Petlan <mpetlan@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]

On Thu, 1 Feb 2024, Namhyung Kim wrote:
> On Wed, Jan 31, 2024 at 3:42 AM Michael Petlan <mpetlan@redhat.com> wrote:
> >
> > From: Veronika Molnarova <vmolnaro@redhat.com>
> >
> > Unify perf regexes for checking testing output into a single file
> > to reduce duplicates and prevent errors when editing.
> >
> > This will be used in upcomming patches in shell tests.
> >
> > Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> > ---
> >  tools/perf/tests/shell/common/patterns.sh | 256 ++++++++++++++++++++++
> >  1 file changed, 256 insertions(+)
> >  create mode 100644 tools/perf/tests/shell/common/patterns.sh
> >
> > diff --git a/tools/perf/tests/shell/common/patterns.sh b/tools/perf/tests/shell/common/patterns.sh
> > new file mode 100644
> > index 000000000000..919a07b8b454
> > --- /dev/null
> > +++ b/tools/perf/tests/shell/common/patterns.sh
> 
> We have tests/shell/lib directory, maybe better to put this there.
> But maybe we can move it later once we apply the series.

Yes, in case the testsuite gets accepted, I plan to work further
on the integration with the current shell test set, in order to
unify the configuration, output, logging, etc. So, I'd prefer to
merge the directories later.
> 
> > @@ -0,0 +1,256 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
[...]

> > +export RE_ADDRESS_NOT_NULL="0x[0-9A-Fa-f]*[1-9A-Fa-f]+[0-9A-Fa-f]*"
> > +# Memory address (not NULL)
> > +# Examples:
> > +#    0xffffffff9abe8ae8
> > +#!   0x0
> > +#!   0x0000000000000000
> > +
> > +export RE_PROCESS_PID="\w+\/\d+"
> 
> I'm afraid the process name can have spaces like
> "my proc A/9876".
> 
> Thanks,
> Namhyung
> 
Good catch! Theoretically yes. It is not used yet (perf-trace tests use
this regexp; we aim to post the rest of the testsuite later). However,
looking at the perf-trace testcase, it runs also `perf trace -a`, so
if there are any processes with non-standard name, they would appear
there. But that's not only space, but also other characters, like '+',
etc. We will try to fix this to match any valid process name. Thanks.

Michael
> > +# A process with PID
> > +# Example:
> > +#    sleep/4102
> > +
> 
>