From: Namhyung Kim <namhyung@kernel.org>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: James Clark <james.clark@linaro.org>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 0/4] tools/build: Allow versioning of all LLVM tools
Date: Fri, 24 Jul 2026 19:31:52 -0400 [thread overview]
Message-ID: <amP16I_cn58hhupT@google.com> (raw)
In-Reply-To: <DK6Z25AV02BM.3KXO0EMCMP2W9@gmail.com>
On Fri, Jul 24, 2026 at 07:19:45PM +0200, Kumar Kartikeya Dwivedi wrote:
> On Thu Jul 16, 2026 at 1:46 AM CEST, Namhyung Kim wrote:
> > Hello BPF folks,
> >
> > On Wed, Jul 15, 2026 at 03:53:47PM +0100, James Clark wrote:
> >> I ran into the build issue mentioned in the first commit, because using
> >> an option like LLVM=-15 is a documented way to build [1], but only
> >> some of the LLVM tools defined in tools/ support this.
> >>
> >> After fixing that, a lot of other tidyups fell out. I didn't go too far,
> >> for example some selftests include tools/testing/selftests/lib.mk which
> >> reimplements some of the LLVM_SUFFIX stuff, but other selftests include
> >> tools/scripts/Makefile.include and I stopped before touching the former.
> >> Some other non build scripts hard code toolchains and I didn't touch
> >> those either, this change is only focused on things that already
> >> include Makefile.include.
> >>
> >> [1]: Documentation/kbuild/llvm.rst
> >>
> >> Signed-off-by: James Clark <james.clark@linaro.org>
> >> ---
> >> Changes in v4:
> >> - Drop "tools/build: selftests: Allow versioning LLVM lld", clang
> >> already picks the correct sibling lld version. (Sashiko)
> >> - Link to v3: https://lore.kernel.org/r/20260715-james-perf-llvm-version-v3-0-8854bfe5af7e@linaro.org
> >>
> >> Changes in v3:
> >> - Add warning for empty $USE_LD
> >> - Use $HOSTREADELF in bpf Makefile
> >> - Rebase on v7.2-rc3
> >> - Link to v2: https://lore.kernel.org/r/20260518-james-perf-llvm-version-v2-0-f12cc4f031d8@linaro.org
> >>
> >> Changes in v2:
> >> - Fix selftests/bpf build. LLD needs to take the full path to be used
> >> with -fuse-ld=
> >> - Link to v1: https://lore.kernel.org/r/20260514-james-perf-llvm-version-v1-0-6cac1a9a4c8d@linaro.org
> >>
> >> ---
> >> James Clark (4):
> >> tools/build: Allow versioning of all LLVM tools defined in Makefile.include
> >> tools/build: Indent if else blocks
> >> tools/build: Allow versioning LLVM readelf
> >> tools/build: selftests: Remove some duplicate toolchain definitions
> >>
> >> tools/bpf/resolve_btfids/Makefile | 3 --
> >> tools/lib/api/Makefile | 4 --
> >> tools/lib/bpf/Makefile | 8 ++--
> >> tools/lib/subcmd/Makefile | 4 --
> >> tools/lib/symbol/Makefile | 4 --
> >> tools/perf/Makefile.perf | 7 ----
> >> tools/scripts/Makefile.include | 77 ++++++++++++++++++++----------------
> >> tools/testing/selftests/bpf/Makefile | 1 -
> >> 8 files changed, 46 insertions(+), 62 deletions(-)
> >
> > Are you ok with this change and going through perf tree?
> >
>
> Sorry for the delay, yes, feel free to take it through your tree.
Thanks, can I take it as your Acked-by?
Namhyung
next prev parent reply other threads:[~2026-07-24 23:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 14:53 [PATCH v4 0/4] tools/build: Allow versioning of all LLVM tools James Clark
2026-07-15 14:53 ` [PATCH v4 1/4] tools/build: Allow versioning of all LLVM tools defined in Makefile.include James Clark
2026-07-15 14:53 ` [PATCH v4 2/4] tools/build: Indent if else blocks James Clark
2026-07-15 14:53 ` [PATCH v4 3/4] tools/build: Allow versioning LLVM readelf James Clark
2026-07-15 20:00 ` Ihor Solodrai
2026-07-15 14:53 ` [PATCH v4 4/4] tools/build: selftests: Remove some duplicate toolchain definitions James Clark
2026-07-15 20:02 ` Ihor Solodrai
2026-07-15 17:24 ` [PATCH v4 0/4] tools/build: Allow versioning of all LLVM tools Ian Rogers
2026-07-15 23:46 ` Namhyung Kim
2026-07-24 17:19 ` Kumar Kartikeya Dwivedi
2026-07-24 23:31 ` Namhyung Kim [this message]
2026-07-24 23:34 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amP16I_cn58hhupT@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox