Re: [PATCH v1 1/3] perf sched: Add missing perf_session__delete()

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, Jul 13, 2026 at 04:00:15PM -0700, Namhyung Kim wrote:
> On Mon, Jul 13, 2026 at 08:59:07PM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > > +++ b/tools/perf/builtin-sched.c
> > > @@ -4027,6 +4027,7 @@ static int perf_sched__schedstat_record(struct perf_sched *sched,
> > >  	else
> > >  		fprintf(stderr, "[ perf sched stats: Failed !! ]\n");
> > >  
> > > +	perf_session__delete(session);
> > >  	evlist__put(evlist);
> > >  	close(fd);
> > 
> > [Severity: Medium]
> > Does adding perf_session__delete() result in closing the file descriptor twice?
> > 
> > Since perf_session__delete() internally closes the file descriptor associated
> > with the session data, the subsequent explicit close(fd) will attempt to
> > close it again. This could return EBADF or erroneously close an unrelated
> > file descriptor if another thread opens a file in the meantime.
> 
> Hmm.. looks right.  I think I can just remove the close().

Ok, waiting for v2 then.

- Arnaldo