Re: [PATCH v1] perf python: Fix ilist TreeNode string type drift

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Thu, Sep 10, 2026 at 05:51:51PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The use of PEP 604 union type syntax `int | float` in function parameters breaks runtime compatibility with Python 3.9.
> --

Waiting for v2,

- Arnaldo
 
> commit 79e3c05b8663765b4c4ea91366e2819e32834d75
> Author: Ian Rogers <irogers@google.com>
> Subject: perf python: Fix ilist TreeNode string type drift
> 
> This commit updates Tree type hints across the perf python ilist module to
> prevent mypy strictness mismatches. It also addresses minor stylistic issues
> reported by mypy, pylint, and Sashiko.
> 
> > diff --git a/tools/perf/python/ilist.py b/tools/perf/python/ilist.py
> > --- a/tools/perf/python/ilist.py
> > +++ b/tools/perf/python/ilist.py
> [ ... ]
> > @@ -343,31 +343,34 @@ class IListApp(App):
> >          if not self.selected or not self.evlist:
> >              return
> >  
> > -        def update_count(cpu: int, count: int):
> > +        def update_count(cpu: int, count: int | float):
> 
> [Severity: Medium]
> Does this new type hint syntax break compatibility with Python 3.9?
> 
> Evaluating the PEP 604 union type syntax int | float as a function parameter
> annotation in Python 3.9 (without from __future__ import annotations) raises
> a TypeError at runtime. 
> 
> Since Python 3.9 is the minimum supported version for kernel auxiliary
> scripts, this will crash the perf userspace tool immediately on startup when
> IListApp.on_mount() calls update_counts(), which defines the update_count
> inner function.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260910174420.3002597-1-irogers@google.com?part=1