Re: [PATCH v2 04/26] perf vendor events intel: Update broadwell metrics to TMA 5.2

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, Sep 28, 2026 at 09:54:50AM -0700, Ian Rogers wrote:
> On Mon, Sep 28, 2026 at 9:49 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Thu, Sep 24, 2026 at 05:14:57PM +0000, sashiko-bot@kernel.org wrote:
> > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> > > - [Medium] perf: missing NO_GROUP_EVENTS_SMT constraint for tma_l3_miss_bound
> > > - [Low] perf: invalid event and metric references in broadwell TMA descriptions
> > > --
> >
> > Hi Ian,
> >
> >         I just saw Mi thanking you for addressing an issue in this
> > series, will you address these Sashiko comments?
> 
> Thanks Arnaldo!
> 
> NO_GROUP_EVENTS_SMT  - this is an optimization to avoid weak group
> fallbacks when SMT is enabled. Applying this tag across all Intel
> models is something of a chore and I'm lazy about it. It isn't a
> critical issue as weak groups (should) work.
> 
> The invalid metrics in the documentation aren't great, but we're
> building the metrics from a spreadsheet. The column containing the
> related metrics doesn't differentiate per model, which is where the
> problem originates. We could validate that metrics are present with
> additional passes over the data; however, fixing this is something we
> need to address in the longer term, in my opinion.

Thanks for the clarification:



Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo