Re: [PATCH v3 3/4] perf symbol: Set dso symtab type for libbfd

[Namhyung Kim <namhyung@kernel.org>]

On Tue, Oct 13, 2026 at 12:08:01AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] perf: missing dso__set_binary_type() initialization for libbfd bypass
> --
> 
> commit 3d059164c2c17ae3b0ec344af1e8527af000eee5
> Author: Namhyung Kim <namhyung@kernel.org>
> 
> perf symbol: Set dso symtab type for libbfd
> 
> It missed to set the dso symtab type when the symbols are loaded by
> libbfd.  When it happens both syms_ss and runtime_ss may not be set
> and won't call dso__load_sym().
> 
> > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> > index 4878d4292eb85..a90ce714b174b 100644
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -1925,6 +1925,7 @@ int dso__load(struct dso *dso, struct map *map)
> >  			nsinfo__mountns_enter(dso__nsinfo(dso), &nsc);
> >  
> >  		if (bfdrc > 0) {
> > +			dso__set_symtab_type(dso, symtab_type);
> 
> [Severity: Medium]
> When dso__load_bfd_symbols() succeeds and we take this early return path, does
> this code also need to set the DSO's binary_type and cross-platform
> architecture flags?
> 
> By taking this goto out_destroy, the rest of the DSO initialization loop is
> bypassed. This leaves the binary_type as DSO_BINARY_TYPE__NOT_FOUND. Later,
> when dso__data_fd() attempts to read instruction bytes for perf annotate or
> Intel PT decoding, try_to_open_dso() will restrict its search to only
> BUILD_ID_CACHE and SYSTEM_PATH_DSO since the actual discovery path wasn't
> recorded.

As I said before, it should be handled in a separate patch series.

> 
> Additionally, bypassing dso__load_sym() means is_64_bit won't be set, which
> causes it to incorrectly default to the host perf binary's pointer size. This
> breaks cross-platform analysis of 32-bit files on 64-bit hosts.

Looks like a pre-existing issue.  I'll add it in a separate patch.

Thanks,
Namhyung

> 
> >  			ret = 1;
> >  			goto out_destroy;
> >  		}
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261012235938.87912-1-namhyung@kernel.org?part=3