Re: [PATCH v2 1/3] perf symbol: Fix symbol loading from libbfd

[Namhyung Kim <namhyung@kernel.org>]

On Sat, Oct 10, 2026 at 06:36:17PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] perf test: pe-file-parsing breaks due to dso__load_bfd_symbols() return value change
> --
> 
> commit 5ad4f779ca47fdb7586a43ebe4942962c3038922
> Author: Namhyung Kim <namhyung@kernel.org>
> 
> perf symbol: Fix symbol loading from libbfd
> 
> This commit modifies dso__load_bfd_symbols() to return a positive number
> representing the number of loaded symbols instead of 0 on success. The caller
> in dso__load() is also updated to check for this positive return value.
> 
> Closes: https://lore.kernel.org/r/sashiko-outbox-162540@kernel.org
> Fixes: eac9a4342e5447cad ("perf symbols: Try reading the symbol table with libbfd")
> 
> > diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c
> > index 33dc6158b2b1f..c2462b54b0e56 100644
> > --- a/tools/perf/util/libbfd.c
> > +++ b/tools/perf/util/libbfd.c
> > @@ -411,7 +411,7 @@ int dso__load_bfd_symbols(struct dso *dso, const char *debugfile)
> >  	symbols__fixup_duplicate(dso__symbols(dso));
> >  	dso__set_adjust_symbols(dso, true);
> >  
> > -	err = 0;
> > +	err = dso__has_symbols(dso);
> 
> [Severity: Medium]
> Does this change break the pe-file-parsing perf test?
> 
> Looking at the pe-file-parsing test in tools/perf/tests/pe-file-parsing.c
> inside run_dir(), it still expects the old 0 return value for success:
> 
>     ret = dso__load_bfd_symbols(dso, debugfile);
>     TEST_ASSERT_VAL("Failed to load symbols", ret == 0);
> 
> Since dso__has_symbols() evaluates to a positive number when symbols exist,
> won't this cause the test suite to unconditionally fail when analyzing valid
> PE files?

Oops, completely missed that.  Will update.

Thanks,
Namhyung