Linux Perf Users
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alireza Haghdoost <haghdoost@uber.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/9] perf symbol: Sorted arrays, DSO-owned lifetimes, and memory shrinking
Date: Thu, 19 Nov 2026 20:33:04 -0800	[thread overview]
Message-ID: <av_NgB044_PInjhM@google.com> (raw)
In-Reply-To: <CAP-5=fXy3L42T03AiSfhmw9pXR5-VTxFK4bKu005tkocJAXp6g@mail.gmail.com>

On Thu, Nov 19, 2026 at 08:31:48AM -0800, Ian Rogers wrote:
> On Wed, Nov 18, 2026 at 11:34 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On Tue, Nov 17, 2026 at 10:52:56AM -0800, Ian Rogers wrote:
> > > When profiling large binaries or long-running workloads with many DSOs and
> > > threads, symbol and DSO tables frequently dominate perf's memory footprint
> > > and startup latency. Currently `struct symbol` has several structural
> > > limitations:
> > >
> > > 1. Every `struct symbol` embeds a 24-byte `struct rb_node` for the
> > >    `dso->symbols` address rbtree, plus an optional negative-offset
> > >    allocation prefix (`symbol_conf.priv_size`) for `struct annotation`
> > >    state even when only a tiny fraction of symbols are ever annotated.
> > > 2. `dso__symbols()` has no internal synchronization against concurrent
> > >    readers/writers, and `struct call_path` (plus Python callchain frames
> > >    and nodes) still retains raw `struct symbol *` pointers without
> > >    retaining a reference on the owning `struct dso`, preventing
> > >    unreferenced DSOs and their symbol tables from being safely reclaimed
> > >    under memory pressure.
> > > 3. ELF symbol table loading (`dso__load_sym_internal()`) repeatedly
> > >    invokes `libelf` section/program header lookups per symbol, calls
> > >    `elf_sym__name()` before filtering out non-function/non-allocated
> > >    symbols, and resorts `dso->symbols` with `qsort()` even when ELF symbol
> > >    tables are already largely ordered in ascending address runs.
> >
> > [...]
> >
> > Applied the first 3 patches to perf-tools-next, thanks!
> 
> Thanks Namhyung! Should I rebase or do anything else for the next 6 patches?

Please read my comments in the thread. :)

Thanks,
Namhyung


      reply	other threads:[~2026-11-20  4:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:52 [PATCH v6 0/9] perf symbol: Sorted arrays, DSO-owned lifetimes, and memory shrinking Ian Rogers
2026-11-17 18:52 ` [PATCH v6 1/9] perf call-path: Use struct dso_symbol to retain symbol DSO lifetimes Ian Rogers
2026-11-17 19:03   ` sashiko-bot
2026-11-17 18:52 ` [PATCH v6 2/9] perf annotate: Move struct annotation to a hashmap and remove symbol_conf.priv_size Ian Rogers
2026-11-17 19:04   ` sashiko-bot
2026-11-17 18:52 ` [PATCH v6 3/9] perf symbol-elf: Cache ELF program/section headers and defer symbol name lookup Ian Rogers
2026-11-17 19:00   ` sashiko-bot
2026-11-17 18:53 ` [PATCH v6 4/9] perf maps: Optimize tail insertion and small-append sorting Ian Rogers
2026-11-17 19:10   ` sashiko-bot
2026-11-18  6:12   ` Namhyung Kim
2026-11-17 18:53 ` [PATCH v6 5/9] perf symbol: Switch backing storage from rbtree to struct symbols array Ian Rogers
2026-11-17 19:17   ` sashiko-bot
2026-11-18  6:28   ` Namhyung Kim
2026-11-17 18:53 ` [PATCH v6 6/9] perf symbol: Optimize symbol sorting with natural-run merge sort and binary insertion Ian Rogers
2026-11-17 19:03   ` sashiko-bot
2026-11-18  6:34   ` Namhyung Kim
2026-11-17 18:53 ` [PATCH v6 7/9] perf symbol: Add memory shrinking for symbols, DSOs, and machines Ian Rogers
2026-11-17 19:25   ` sashiko-bot
2026-11-17 18:53 ` [PATCH v6 8/9] perf session: Add dso__session() and session-scoped allocation wrappers Ian Rogers
2026-11-17 19:15   ` sashiko-bot
2026-11-17 18:53 ` [PATCH v6 9/9] perf test symbols: Add tests for symbol shrinking and session alloc wrappers Ian Rogers
2026-11-17 19:14   ` sashiko-bot
2026-11-19  7:34 ` [PATCH v6 0/9] perf symbol: Sorted arrays, DSO-owned lifetimes, and memory shrinking Namhyung Kim
2026-11-19 16:31   ` Ian Rogers
2026-11-20  4:33     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av_NgB044_PInjhM@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=haghdoost@uber.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox