From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794851492; b=NYWVALJMlZBC2XpMjv/QbAru0zg/wq8SE2rlzxfVpbRp7WUs6U7L6AkG0WEei7jLalAb qS+kH4sFYrdHCQ0cbNKF2JssJc8n5R7rIPUjL07FoS0qfH2+BNlWAdZqoOsaJdu0F4HmL loCenW0Y7QTu12u8VZjZkAtC9MUCAnBuYhT3rvoSztd3WMhmRlXvEZjlOZGOrNQTHZyVq /JeJX4h5/4gHQ5AdoKxdF2WofoIrl3TFLzQLXwoS8oW1p0B9Di7zslvjI8t5js8I4H1Cu i1S7Sc5+LkuHC64Rz2vjYkOUZ8TheDZyNxjOI08p34Q8T8JzJkBJKNjwFYF7mKV4FBA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794851492; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=blGIJDCDss+E3b9SqzgbEdlWTUpb2T+aJik+W4Q8e9Y=; b=3wpiNUx5TwO9xoRGzebqSXwPB4NlPOGjGVn/Csz2SAn2svn0XwMKot0wCW3U0rD3Tc5O 7URJJgnruHKmNZgbhrbXEoFkXdPSZNALriPEiaGtJbykuAapj4iBpByaQfOwRcCmtu56a zaMzcXDpukbomOyo/NUjM5A/HQojS4Y9SlWRXKN96WJloUlAbUV5IjbhJR7Kyr9dilJBS TQS2iLTN7udBHK/NUpqPic4DHtXqHHNuy10rZo/WDPnRWt+IQt62DybzbdXRUa2m5pnQ9 z9CM+hiTEARHquROTyBtcxXeqfj2kZ9c6zc4aOGnNjSQfDUw8eMaC0FypXiEiL8Wt+g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=TuSee7pi; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20DCC606A891; Mon, 16 Nov 2026 17:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=TuSee7pi Received: by smtp.kernel.org (Postfix) with ESMTPSA id 290F51F000C4; Mon, 16 Nov 2026 17:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794851492; bh=blGIJDCDss+E3b9SqzgbEdlWTUpb2T+aJik+W4Q8e9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TuSee7pijL/EQxTZBDS2rvh9VhYUoswVcG+r5Rfl+jzNs9/BAeEA+G64PHMQljEW4 S7+o2QcBzV702jg+VlVZ8U1n54eSLYBffN0NJagqWuWShBpfKdl7g64a6qJTsZdjtp uo27CFZfolNpxff3rCt5GoXjpBUS4UCmkjE4y7FrYprtQE8H5Z3M1Dbi67VA3R92IN vJYjoXxHlMokNSSaxfRvRZCrmrdiW5iraCRMUDAxw2kwl3p0Oin+ILPZFgHPaPcRgv ayWoJKO5MJUOllsnyyLN1vcPoBndg3uq5ncW3/V8OCovO2qRViX3sEYv4YGIexL4vR s9kNVS4WatYdQ== Date: Mon, 16 Nov 2026 17:51:25 +0000 From: "Lorenzo Stoakes (ARM)" To: Alexandru Elisei Cc: maz@kernel.org, oupton@kernel.org, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, will@kernel.org, mark.rutland@arm.com, linux-perf-users@vger.kernel.org, catalin.marinas@arm.com, james.clark@linaro.org Subject: Re: [RFC PATCH v7 00/28] KVM: arm64: Add Statistical Profiling Extension (SPE) support Message-ID: References: <20260903160623.315525-1-alexandru.elisei@arm.com> X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 06, 2026 at 11:41:52AM +0000, Alexandru Elisei wrote: > Hi Lorenzo, > > On Thu, Nov 05, 2026 at 05:47:45PM +0000, Lorenzo Stoakes (ARM) wrote: > > Hi Alex, > > > > I've gone through all of the patches now, thank you for your patience with > > the review :) > > Many thanks for the stellar review, will start replying soonish. > > > > > So there are various dependencies/architectural decisions that need to be > > made here to go from RFC -> non-RFC: > > > > 1. The 'Ignore MMU notifiers for guest_memfd-only memslots' patch [0] is a > > hard dependency for the series. I chased over there, hopefully we can > > get something landed there. > > Like you said, Sean is planning to send my original version of that patch with > an updated commit message, thanks for the ping! No worries! :) > > > > > 2. non-VHE, pKVM, NV disallowed for SPE - As I mentioned off-list, I spoke > > to Marc, and he confirmed that he's more than happy for these to be off > > the table for a v1. So I think you can drop the HACK: patches and just > > make these conditions of using SPE. > > Oliver, some time ago, expressed the opposite preference: VHE-only is OK for an > RFC, but he was concerned about the discrepancy between VHE and nVHE > configurations. Maybe the direction for KVM changed in the meantime. > > Fine by me to drop the HACK! patches, of course, that's just something to keep > in mind. Ack, Oliver - let us know if this is a problem (Marc suggested he was fine with requiring VHE), I think certainly it's useful most of all to move forwards without the 'HACK' patches, and with the various architectural points raised here addressed we can look to a non-RFC series. And obviously we can update as necessary as we go based on maintainer requirements. > > > > > 3. The entire VM needs to be pre-faulted, but who should do it? - I do > > think that relying on userland to do this is a little iffy. So I wonder > > There's plenty of iffiness that userspace already handles when it comes to > virtual machines. Yup, does seem to be a fair bit of implicit assumptions of sanity :) > > Or, how Oliver put it [1] (regarding migration, but it fits): > > 'My take is that there's no amount of idiot-proofing we can do in KVM to prevent > the VMM from messing this up somehow'. Haha, right. I guess fine to require userland to set things up like that, and can always add an option to have it automatically set up for them in future as a nice-to-have. I want to separate out the gmem bit though, replying below: > > [1] https://lore.kernel.org/kvm/alE3jRLtYeq-WesA@kernel.org/ > > > whether it might be possible to, on SPE first run, prefault the ranges > > there, and make that a condition of using it? Relatedly, KVM could > > reject non-guest_memfd memslots for an SPE VM rather than trusting > > userspace there too. > > I'm not sure that's the best idea. Mainly two reasons: > > 1. KVM will be imposing the condition that *all* writable memslots be backed by > guest_memfd, and *all* memory backing these memslots be pre-faulted and > effectively pinned. I mean this really is a requirement for SPE to work at all, since the guest is effectively deciding which memory is being used for SPE (I think it's perf AUX memory right?) I think given that it's guest-designated _and_ the guest has no idea which parts of memory are 'SPE safe' and 'SPE unsafe', this is a requirement. > > There are use cases for writable memslots to describe guest memory that won't be > used by SPE. First thing that comes to mind would be paravirtualized interfaces > between host userspace and the guest. For example, pvtime - kvmtool creates a > RAM memslot for pvtime (i.e, non-read-only memslot), and it looks to me that > qemu does the same (but my knowledge of qemu is severely limited, so I might be > completely wrong). I don't think any of this is disallowed by the gmem requirement. > > Then there's also the possibility that a guest might want to assign a slice of > RAM for use by SPE, to avoid pre-faulting and pinning the entire VM memory. In > this case, userspace will want to have *only* the memslot describing that slice > pre-faulted and pinned, and not the rest of system memory. As above, there's just no way for userspace to know which bits of memory are SPE safe and which are not. So I don't think this works. > > 2. Perfomance - userspace can pre-fault in parallel, KVM cannot easily do that. > > arm64 now has support for KVM_PRE_FAULT_MEMORY, I say let's use that :) :) right. OK, so maybe the right path then is to keep the prefaulting with userspace, but I really do think we have to have KVM reject a writable non-gmem memslot once SPE is enabled for the VM (and reject enabling SPE if one already exists). That should be relatively straightforward and avoids at least the most broken userland mistakes. > > > > > 4. Dirty page logging - patch 27/28 relies on series [1] being landed, > > which is also an RFC, and allows migration of SPE VMs. So we need to > > decide - do we want this migration? Additionally, I think it's > > reasonable to, if we want it, send both [1] and patch 27/28 as a follow > > up separate from the v1 non-RFC of the series. > > For background, I started this conversation in the LOG_DIRTY_PAGES support for > guest_memfd series [2]. Oliver had some concerns, but he didn't follow up on my > explanations, so I decided to send migration support as part of SPE so people > can have a more complete picture of how everything fits together. > > I would be very happy to get basic support for SPE merged in KVM, and, if we > decide it's useful, migration implemented as a follow up, as that involves > landing dirty page logging support for guest_memfd. Ack, thanks, let's treat that as a follow-up then, I think best thing here is definitely to focus on getting the fundamental bits in for SPE first. > > [2] https://lore.kernel.org/kvm/alAFmiAsNf6Xm49_@kernel.org/ > > > > > 5. Errata handling - the default already disallows SPE on the affected > > silicon, which seems right. I wonder whether kvm-arm.ignore_spe_errata > > should exist at all though, other than in some sort of debug mode. > > It is intended as a debug/development option, to be used only when the VMs are > trusted. As to why it's there, it's there because without it, SPE would be > disabled on all the machines that I have access to, and I suspect systems not > affected are few and rare between. Ack ok that clarifies that :) let's then clearly mark that as such e.g. 'debug/development only, trusted VMs only' in the documentation, and tainting the kernel if it's enabled, I think, would be sensible. > > > > > So 1 is a known dependency, I think there's no getting around that, and > > thus that makes merging [0] or something like it a top priority. > > > > It seems to me 2 is pretty clear-cut, and 4 can reasonably (if we want it) > > be sent as a follow up. > > > > So really 3 and 5 are the decisions to make here! > > I really appreciate your enthusiasm, thanks! No worries :) am happy to put in some work on my side to help move things forwards (and obviously more than happy to help with review on respins of course :) > > Alex -- Cheers, Lorenzo