linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: will@kernel.org, mark.rutland@arm.com, linux-cxl@vger.kernel.org,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/cxlpmu: Fix allocation argument order and minor formatting issues
Date: Tue, 24 Jun 2025 23:01:37 +0530	[thread overview]
Message-ID: <b26e684c-1790-44dc-8191-7326fcb2c25a@oracle.com> (raw)
In-Reply-To: <20250624153644.0000084f@huawei.com>



On 6/24/2025 8:06 PM, Jonathan Cameron wrote:
>> Correct the argument order in devm_kcalloc() to follow the conventional
>> count, size form to avoid any confusion or bugs.
>> Also fix a formatting issue in the devm_kasprintf() call by removing a
>> stray newline and fix a duplicated word in a comment.
>>
>> Signed-off-by: Alok Tiwari<alok.a.tiwari@oracle.com>
> Hi Alok,
> 
> This is a bit of an 'and' patch which usually means it should
> be split up.  The devm_kcalloc() is a fix (sort of anyway)
> which the others changes aren't.
> 
> All the actual changes are good, I'd just prefer this as a little series
> of patches that do one thing each.  The first being the devm_kcalloc()
> parameter ordering.
> 
> Thanks,
> 
> Jonathan


Thanks a lot Jonathan. I will send patch series


Thanks
Alok

      reply	other threads:[~2025-06-24 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 18:44 [PATCH] perf/cxlpmu: Fix allocation argument order and minor formatting issues Alok Tiwari
2025-06-24 14:36 ` Jonathan Cameron
2025-06-24 17:31   ` ALOK TIWARI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b26e684c-1790-44dc-8191-7326fcb2c25a@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).