From: John Garry <john.g.garry@oracle.com>
To: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
Zhuo Song <zhuo.song@linux.alibaba.com>,
Shuai Xue <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v5 1/5] perf metric: Event "Compat" value supports matching multiple identifiers
Date: Wed, 2 Aug 2023 10:43:56 +0100 [thread overview]
Message-ID: <b471c336-92dc-af42-dfd2-62831fd6dd60@oracle.com> (raw)
In-Reply-To: <8e207c71-5400-5427-ae83-a1e0b8f95e31@linux.alibaba.com>
On 02/08/2023 10:38, Jing Zhang wrote:
>>>> n;
>>>> +
>>>> + str = strdup(compat);
>>> why duplicate this? are you modifying something?
>>>
>> This is really a redundant step, I will remove it.
>>
> Hi John,
>
> I reviewed this code again and found that it still needs to duplicate "compat" because "compat" is a
> const str* type and cannot be used as a parameter for the strtok_r function. If it is cast to char*,
> using "compat" as a parameter for strtok_r is also unsafe and can cause a "Segmentation fault" error.
> Therefore, let's keep the step of duplicating "compat".
ok, so then please add a small comment on why the strdup() call is needed.
Thanks,
John
next prev parent reply other threads:[~2023-08-02 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 6:17 [PATCH v5 0/5] Add aliases and metrics for Arm CMN Jing Zhang
2023-07-28 6:17 ` [PATCH v5 1/5] perf metric: Event "Compat" value supports matching multiple identifiers Jing Zhang
2023-07-28 8:11 ` John Garry
2023-07-31 10:59 ` Jing Zhang
2023-07-31 13:16 ` John Garry
2023-08-02 9:38 ` Jing Zhang
2023-08-02 9:43 ` John Garry [this message]
2023-08-02 9:47 ` Jing Zhang
2023-07-28 6:17 ` [PATCH v5 2/5] perf jevents: Support more event fields Jing Zhang
2023-07-28 6:17 ` [PATCH v5 3/5] perf test: Add pmu-event test for "Compat" and new event_field Jing Zhang
2023-07-28 8:30 ` John Garry
2023-07-31 12:30 ` Jing Zhang
2023-07-31 13:12 ` John Garry
2023-08-01 9:19 ` Jing Zhang
2023-08-01 15:10 ` John Garry
2023-08-02 3:49 ` Jing Zhang
2023-07-28 6:17 ` [PATCH v5 4/5] perf jevents: Add support for Arm CMN PMU aliasing Jing Zhang
2023-07-28 8:17 ` John Garry
2023-07-31 12:31 ` Jing Zhang
2023-07-28 6:17 ` [PATCH v5 5/5] perf vendor events: Add JSON metrics for Arm CMN Jing Zhang
2023-07-28 8:18 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b471c336-92dc-af42-dfd2-62831fd6dd60@oracle.com \
--to=john.g.garry@oracle.com \
--cc=acme@kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).