From: John Garry <john.g.garry@oracle.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org,
Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH 2/4] perf vendor events arm64: AmpereOne: Mark affected STALL_* events impacted by errata
Date: Fri, 4 Aug 2023 12:05:15 +0100 [thread overview]
Message-ID: <b690cae6-ee9c-2c6b-a19e-60088cb8cb19@oracle.com> (raw)
In-Reply-To: <20230803211331.140553-3-ilkka@os.amperecomputing.com>
On 03/08/2023 22:13, Ilkka Koskinen wrote:
> Per errata AC03_CPU_29, STALL_SLOT_FRONTEND, STALL_FRONTEND, and STALL
> events are not counting as expected. The follow up metrics patch will
> include correct way to calculate the impacted events.
>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
> ---
> .../arch/arm64/ampere/ampereone/pipeline.json | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
> index f9fae15f7555..711028377f3e 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/pipeline.json
> @@ -1,18 +1,24 @@
> [
> {
> - "ArchStdEvent": "STALL_FRONTEND"
> + "ArchStdEvent": "STALL_FRONTEND",
> + "Errata": "Errata AC03_CPU_29",
> + "BriefDescription": "Impacted by errata, use metrics instead -"
why end with a '-'?
> },
> {
> "ArchStdEvent": "STALL_BACKEND"
> },
> {
> - "ArchStdEvent": "STALL"
> + "ArchStdEvent": "STALL",
> + "Errata": "Errata AC03_CPU_29",
> + "BriefDescription": "Impacted by errata, use metrics instead -"
> },
> {
> "ArchStdEvent": "STALL_SLOT_BACKEND"
> },
> {
> - "ArchStdEvent": "STALL_SLOT_FRONTEND"
> + "ArchStdEvent": "STALL_SLOT_FRONTEND",
> + "Errata": "Errata AC03_CPU_29",
> + "BriefDescription": "Impacted by errata, use metrics instead -"
> },
> {
> "ArchStdEvent": "STALL_SLOT"
next prev parent reply other threads:[~2023-08-04 11:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 21:13 [PATCH 0/4] perf vendor events arm64: AmpereOne: Core PMU event update and metrics Ilkka Koskinen
2023-08-03 21:13 ` [PATCH 1/4] perf vendor events arm64: Remove L1D_CACHE_LMISS from AmpereOne list Ilkka Koskinen
2023-08-04 11:02 ` John Garry
2023-08-14 17:36 ` Ian Rogers
2023-08-03 21:13 ` [PATCH 2/4] perf vendor events arm64: AmpereOne: Mark affected STALL_* events impacted by errata Ilkka Koskinen
2023-08-04 11:05 ` John Garry [this message]
2023-08-04 19:40 ` Ilkka Koskinen
2023-08-10 22:38 ` Ilkka Koskinen
2023-08-11 10:08 ` John Garry
2023-08-03 21:13 ` [PATCH 3/4] perf vendor events arm64: Add AmpereOne metrics Ilkka Koskinen
2023-08-04 11:09 ` John Garry
2023-08-04 19:59 ` Ilkka Koskinen
2023-08-07 12:07 ` John Garry
2023-08-09 0:00 ` Ilkka Koskinen
2023-08-14 17:47 ` Ian Rogers
2023-08-14 18:49 ` Ilkka Koskinen
2023-08-03 21:13 ` [PATCH 4/4] perf vendor events arm64: AmpereOne: Remove unsupported events Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b690cae6-ee9c-2c6b-a19e-60088cb8cb19@oracle.com \
--to=john.g.garry@oracle.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dave.kleikamp@oracle.com \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).