From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: mingo@redhat.co, peterz@infradead.org, namhyung@kernel.org
Subject: Re: [PATCH] perf/core: make nr_addr_filters attribute static
Date: Mon, 12 Jan 2026 13:31:06 +0800 [thread overview]
Message-ID: <b79ba06d-ec06-4f8f-85cf-72ea6080b041@linux.intel.com> (raw)
In-Reply-To: <20260109122732.388307-1-ben.dooks@codethink.co.uk>
On 1/9/2026 8:27 PM, Ben Dooks wrote:
> The 'dev_attr_nr_addr_filters' attribute is not exported
> outside of the kernel/events/core.c file so make it static
> to avoid the following sparse warning:
>
> kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
>
> Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index dad0d3d2e85f..b79f9be8f074 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
>
> return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
> }
> -DEVICE_ATTR_RO(nr_addr_filters);
> +static DEVICE_ATTR_RO(nr_addr_filters);
>
> static struct idr pmu_idr;
>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
prev parent reply other threads:[~2026-01-12 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 12:27 [PATCH] perf/core: make nr_addr_filters attribute static Ben Dooks
2026-01-12 5:31 ` Mi, Dapeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b79ba06d-ec06-4f8f-85cf-72ea6080b041@linux.intel.com \
--to=dapeng1.mi@linux.intel.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.co \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox