* [PATCH] perf/core: make nr_addr_filters attribute static
@ 2026-01-09 12:27 Ben Dooks
2026-01-12 5:31 ` Mi, Dapeng
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2026-01-09 12:27 UTC (permalink / raw)
To: linux-kernel, linux-perf-users; +Cc: mingo, peterz, namhyung, Ben Dooks
The 'dev_attr_nr_addr_filters' attribute is not exported
outside of the kernel/events/core.c file so make it static
to avoid the following sparse warning:
kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index dad0d3d2e85f..b79f9be8f074 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
}
-DEVICE_ATTR_RO(nr_addr_filters);
+static DEVICE_ATTR_RO(nr_addr_filters);
static struct idr pmu_idr;
--
2.37.2.352.g3c44437643
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf/core: make nr_addr_filters attribute static
2026-01-09 12:27 [PATCH] perf/core: make nr_addr_filters attribute static Ben Dooks
@ 2026-01-12 5:31 ` Mi, Dapeng
0 siblings, 0 replies; 2+ messages in thread
From: Mi, Dapeng @ 2026-01-12 5:31 UTC (permalink / raw)
To: Ben Dooks, linux-kernel, linux-perf-users; +Cc: mingo, peterz, namhyung
On 1/9/2026 8:27 PM, Ben Dooks wrote:
> The 'dev_attr_nr_addr_filters' attribute is not exported
> outside of the kernel/events/core.c file so make it static
> to avoid the following sparse warning:
>
> kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
>
> Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index dad0d3d2e85f..b79f9be8f074 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
>
> return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
> }
> -DEVICE_ATTR_RO(nr_addr_filters);
> +static DEVICE_ATTR_RO(nr_addr_filters);
>
> static struct idr pmu_idr;
>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-12 5:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 12:27 [PATCH] perf/core: make nr_addr_filters attribute static Ben Dooks
2026-01-12 5:31 ` Mi, Dapeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox