From: "Rémi Bernon" <rbernon@codeweavers.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf symbol: Look for ImageBase in PE file to compute .text offset
Date: Mon, 13 Sep 2021 22:37:47 +0200 [thread overview]
Message-ID: <bca46af1-e2b8-a92b-c796-86d21bfecec6@codeweavers.com> (raw)
In-Reply-To: <YT+lhAhBGprnMT7P@kernel.org>
On 9/13/21 9:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Sun, Sep 12, 2021 at 10:25:26AM +0200, Rémi Bernon escreveu:
>> On 9/9/21 10:27 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, Sep 09, 2021 at 09:26:36PM +0200, Remi Bernon escreveu:
>>>> Instead of using the file offset in the debug file.
>>>>
>>>> This fixes a regression from 00a3423492bc90be99e529a64f13fdd80a0e8c0a,
>>>> causing incorrect symbol resolution when debug file have been stripped
>>>> from non-debug sections (in which case its .text section is empty and
>>>> doesn't have any file position).
>>>>
>>>> The debug files could also be created with a different file alignment,
>>>> and have different file positions from the mmap-ed binary, or have the
>>>> section reordered.
>>>>
>>>> This instead looks for the file image base, using the corresponding bfd
>>>> *ABS* symbols. As PE symbols only have 4 bytes, it also needs to keep
>>>> .text section vma high bits.
>>>
>>> I added a:
>>>
>>> Fixes: 00a3423492bc90be ("perf symbols: Make dso__load_bfd_symbols() load PE files from debug cache only")
>>>
>>> To help stable@kernel.org to pick it, its on my local tree now.
>>>
>>> It would be great to get a:
>>>
>>> Reviewed-by: Nicholas Fraser <nfraser@codeweavers.com>
>>>
>>> Can we have it, please?
>>>
>>
>> Well, Nicholas doesn't work with us anymore. I've reached them separately
>> but didn't get any answer so I'm thinking they may not be interested.
>
> No problem, its already upstream now.
>
> Thanks,
>
> - Arnaldo
>
Awesome, thanks!
--
Rémi Bernon <rbernon@codeweavers.com>
prev parent reply other threads:[~2021-09-13 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 19:26 [PATCH] perf symbol: Look for ImageBase in PE file to compute .text offset Remi Bernon
2021-09-09 20:27 ` Arnaldo Carvalho de Melo
2021-09-12 8:25 ` Rémi Bernon
2021-09-13 19:24 ` Arnaldo Carvalho de Melo
2021-09-13 20:37 ` Rémi Bernon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca46af1-e2b8-a92b-c796-86d21bfecec6@codeweavers.com \
--to=rbernon@codeweavers.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).