From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gerstmayr Subject: Re: [PATCH] perf script report: fix segfault when using DWARF mode Date: Fri, 3 Apr 2020 15:16:48 +0200 Message-ID: References: <05e0d633-54b4-fb3b-3d08-8963271017ea@amd.com> <20200402125417.422232-1-agerstmayr@redhat.com> <6a098ce1-1981-dcff-ea62-af5fc07ec7fb@amd.com> <20200403124028.GA18559@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200403124028.GA18559@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Arnaldo Carvalho de Melo , Kim Phillips Cc: linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , "Steven Rostedt (VMware)" , Kan Liang , linux-kernel@vger.kernel.org List-Id: linux-perf-users.vger.kernel.org On 03.04.20 14:40, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 02, 2020 at 02:07:51PM -0500, Kim Phillips escreveu: >> On 4/2/20 7:54 AM, Andreas Gerstmayr wrote: >>> When running perf script report with a Python script and a callgraph in >>> DWARF mode, intr_regs->regs can be 0 and therefore crashing the regs_map >>> function. >>> >>> Added a check for this condition (same check as in builtin-script.c:595). >>> >>> Signed-off-by: Andreas Gerstmayr >>> --- >> >> Tested-by: Kim Phillips > > Thanks, added this to that patch. > Great, thanks! Cheers, Andreas