From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18F0C433FE for ; Wed, 10 Nov 2021 08:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AD9161205 for ; Wed, 10 Nov 2021 08:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbhKJIbG (ORCPT ); Wed, 10 Nov 2021 03:31:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46814 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229831AbhKJIbG (ORCPT ); Wed, 10 Nov 2021 03:31:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636532898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U3N/QwJx99Htv9Bvod8btoHFfpBRUV5/sWEz28i4RYo=; b=FsESyu9r1b/v48FiWdwordYEPGOp+otgPYa6y7o9y4EvfSmvA2VBK5+rN3C0v1/TOeu1AA P2POoRa0I+R+PL9oBuMmDxLhPE53TbqvDSTbAABXAoGO0BEYlMRzRuTg3ovb4mwr336+l+ IQxjOzkBVddcCUJ+YwBv7Ds3XY/iJkE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-kzspWDkrMxavNLISoKka8w-1; Wed, 10 Nov 2021 03:28:17 -0500 X-MC-Unique: kzspWDkrMxavNLISoKka8w-1 Received: by mail-wm1-f71.google.com with SMTP id b145-20020a1c8097000000b003335872db8dso183436wmd.2 for ; Wed, 10 Nov 2021 00:28:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=U3N/QwJx99Htv9Bvod8btoHFfpBRUV5/sWEz28i4RYo=; b=M3jH3b04J2DHA3qLjhwEhOcY7dVOgAYOj8dKC+RjERoSk548oTqJWuFmH4Irop0Yb3 IQkZQZSUkt0Xx7XQQgYH7ud6oMUkZREmGAXUvHkje58TbG/eb7mWD6clhwdrMnUXG9BN pkX04DXFZ9JFytJHVR8DkHHeujgBqr3di4bMRQXGc/PlrXovv0ZOGZUYOFNivGHgO9RW rmj9veHO5MTt0gxlRRtXDnqXKNjbtW1CP6b0bc2R2taAf5a6n8r0G/Ip27iQ3NJmZMF9 oPepTkTgJ1SjtQNWMRfbErTpt0cCXVKcLTZOJCpv9tnP+zq+xMPiPtXH0TBbA/uzNSwH 8/vA== X-Gm-Message-State: AOAM530Y+/I9BdG/1x9nSYJKlxrrYKi7of/N9XBraIy6Tant1N0TCUdC egJQxkkrA1lFFVExriHTD4RyYkN/7BFHmerivCDZ882vofiKdTEO9lQiGQfQId7YxuPoYn4wqlw +U17iTCuDaBPBk4n9gxZLWnT1Ilmz3Q== X-Received: by 2002:adf:ba0d:: with SMTP id o13mr17628072wrg.339.1636532896088; Wed, 10 Nov 2021 00:28:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQ/2kqjTXPkYPHvyddhqvtTW4vWEhMZpSvnii4YyiM1CY6/ErutfetxXoUCqfLbvvZpl1HaA== X-Received: by 2002:adf:ba0d:: with SMTP id o13mr17628047wrg.339.1636532895920; Wed, 10 Nov 2021 00:28:15 -0800 (PST) Received: from [192.168.3.132] (p5b0c604f.dip0.t-ipconnect.de. [91.12.96.79]) by smtp.gmail.com with ESMTPSA id u23sm15854437wru.21.2021.11.10.00.28.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 00:28:14 -0800 (PST) Message-ID: Date: Wed, 10 Nov 2021 09:28:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 1/7] fs/exec: make __set_task_comm always set a nul terminated string Content-Language: en-US To: Yafang Shao , akpm@linux-foundation.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Petr Mladek References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-2-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211108083840.4627-2-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 08.11.21 09:38, Yafang Shao wrote: > Make sure the string set to task comm is always nul terminated. > strlcpy: "the result is always a valid NUL-terminated string that fits in the buffer" The only difference seems to be that strscpy_pad() pads the remainder with zeroes. Is this description correct and I am missing something important? > Signed-off-by: Yafang Shao > Reviewed-by: Kees Cook > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- > fs/exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exec.c b/fs/exec.c > index a098c133d8d7..404156b5b314 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1224,7 +1224,7 @@ void __set_task_comm(struct task_struct *tsk, const char *buf, bool exec) > { > task_lock(tsk); > trace_task_rename(tsk, buf); > - strlcpy(tsk->comm, buf, sizeof(tsk->comm)); > + strscpy_pad(tsk->comm, buf, sizeof(tsk->comm)); > task_unlock(tsk); > perf_event_comm(tsk, exec); > } > -- Thanks, David / dhildenb