Re: [PATCH v8 3/8] perf vendor events: Supplement the omitted EventCode

[Jing Zhang <renyu.zj@linux.alibaba.com>]

在 2023/9/13 上午4:34, Arnaldo Carvalho de Melo 写道:
> Em Mon, Sep 11, 2023 at 10:41:16AM +0800, Jing Zhang escreveu:
>>
>> 在 2023/9/9 上午5:18, Ian Rogers 写道:
>>> On Thu, Sep 7, 2023 at 4:58 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote:
>>>> If there is an "event=0" in the event description, the EventCode can
>>>> be omitted in the JSON file, and jevent.py will automatically fill in
>>>> "event=0" during parsing.
>>>>
>>>> However, for some events where EventCode and ConfigCode are missing,
>>>> it is not necessary to automatically fill in "event=0", such as the
>>>> CMN event description which is typically "type=xxx, eventid=xxx".
>>>>
>>>> Therefore, before modifying jevent.py to prevent it from automatically
>>>> adding "event=0" by default, it is necessary to fill in all omitted
>>>> EventCodes first.
>>>>
>>>> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
>>> I thought you were going to change the behavior in jevents.py so this
>>> change would be unnecessary. The next time the json is generated by
>>> the script:
>>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
>>> then this will break. It seems easier to workaround the issue in jevents.py.
>>>
>> Okay, I will workaround the issue in jevents.py. Thank you!
> So this means you will resubmit the whole 8-patches long series or
> should we merge this one and then get a followup patch?
> 

Please wait for v9 as there are still some unresolved issues in this series.

Thanks,
Jing

> - Arnaldo
>  
>>> Thanks,
>>> Ian