From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CF6EE57CC for ; Wed, 13 Sep 2023 02:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235255AbjIMCCu (ORCPT ); Tue, 12 Sep 2023 22:02:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233016AbjIMCCt (ORCPT ); Tue, 12 Sep 2023 22:02:49 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA95510FE; Tue, 12 Sep 2023 19:02:44 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VryYWRC_1694570559; Received: from 30.221.149.124(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VryYWRC_1694570559) by smtp.aliyun-inc.com; Wed, 13 Sep 2023 10:02:40 +0800 Message-ID: Date: Wed, 13 Sep 2023 10:02:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v8 3/8] perf vendor events: Supplement the omitted EventCode To: Arnaldo Carvalho de Melo Cc: Ian Rogers , John Garry , Will Deacon , James Clark , Mark Rutland , Mike Leach , Leo Yan , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue References: <1694087913-46144-1-git-send-email-renyu.zj@linux.alibaba.com> <1694087913-46144-4-git-send-email-renyu.zj@linux.alibaba.com> <01eecef3-a918-a6d0-6f9f-d3b99c9680a8@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org 在 2023/9/13 上午4:34, Arnaldo Carvalho de Melo 写道: > Em Mon, Sep 11, 2023 at 10:41:16AM +0800, Jing Zhang escreveu: >> >> 在 2023/9/9 上午5:18, Ian Rogers 写道: >>> On Thu, Sep 7, 2023 at 4:58 AM Jing Zhang wrote: >>>> If there is an "event=0" in the event description, the EventCode can >>>> be omitted in the JSON file, and jevent.py will automatically fill in >>>> "event=0" during parsing. >>>> >>>> However, for some events where EventCode and ConfigCode are missing, >>>> it is not necessary to automatically fill in "event=0", such as the >>>> CMN event description which is typically "type=xxx, eventid=xxx". >>>> >>>> Therefore, before modifying jevent.py to prevent it from automatically >>>> adding "event=0" by default, it is necessary to fill in all omitted >>>> EventCodes first. >>>> >>>> Signed-off-by: Jing Zhang >>> I thought you were going to change the behavior in jevents.py so this >>> change would be unnecessary. The next time the json is generated by >>> the script: >>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py >>> then this will break. It seems easier to workaround the issue in jevents.py. >>> >> Okay, I will workaround the issue in jevents.py. Thank you! > So this means you will resubmit the whole 8-patches long series or > should we merge this one and then get a followup patch? > Please wait for v9 as there are still some unresolved issues in this series. Thanks, Jing > - Arnaldo > >>> Thanks, >>> Ian