From: Adrian Hunter <adrian.hunter@intel.com>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf inject: Clarify build-id options a little bit
Date: Wed, 14 Sep 2022 08:11:20 +0300 [thread overview]
Message-ID: <ca460f5e-644f-8c55-670f-76d8a6f95e40@intel.com> (raw)
In-Reply-To: <20220914040844.352514-1-namhyung@kernel.org>
On 14/09/22 07:08, Namhyung Kim wrote:
> Update the documentation of --build-id and --buildid-all options to
> clarify the difference between them. The former requires full sample
> processing to find which DSOs are actually used. While the latter simply
> injects every DSO's build-id from MMAP{,2} records, skipping SAMPLEs.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/Documentation/perf-inject.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
> index 70e2ac3cc91a..c972032f4ca0 100644
> --- a/tools/perf/Documentation/perf-inject.txt
> +++ b/tools/perf/Documentation/perf-inject.txt
> @@ -25,10 +25,12 @@ OPTIONS
> -------
> -b::
> --build-ids::
> - Inject build-ids into the output stream
> + Inject build-ids of DSOs hit by samples into the output stream.
> + This means it needs to process all SAMPLE records to find the DSOs.
>
> --buildid-all::
> - Inject build-ids of all DSOs into the output stream
> + Inject build-ids of all DSOs into the output stream regardless of hits
> + and skip SAMPLE processing.
>
> --known-build-ids=::
> Override build-ids to inject using these comma-separated pairs of
prev parent reply other threads:[~2022-09-14 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 4:08 [PATCH] perf inject: Clarify build-id options a little bit Namhyung Kim
2022-09-14 5:11 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca460f5e-644f-8c55-670f-76d8a6f95e40@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).