From: James Clark <james.clark@linaro.org>
To: mark.barnett@arm.com
Cc: ben.gainey@arm.com, deepak.surti@arm.com, ak@linux.intel.com,
will@kernel.org, james.clark@arm.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
irogers@google.com
Subject: Re: [PATCH v2 0/5] A mechanism for efficient support for per-function metrics
Date: Wed, 22 Jan 2025 16:47:22 +0000 [thread overview]
Message-ID: <ca8de228-68c2-4b2c-bb58-30f275afc49e@linaro.org> (raw)
In-Reply-To: <20250106120156.227273-1-mark.barnett@arm.com>
On 06/01/2025 12:01 pm, mark.barnett@arm.com wrote:
> From: Mark Barnett <mark.barnett@arm.com>
>
> This patch introduces the concept of an alternating sample rate to perf
> core and provides the necessary basic changes in the tools to activate
> that option.
>
[...]
> Changes since v1:
> - Rebased onto perf-tools-next, as per request from Ian Rogers.
> - Removed unnecessary code that truncated period_left to 0 and restarted
> the PMU.
> - Renamed variables to use the shorter 'alt_period' instead of
> 'alterantive_period'.
> - Added patch #5 that addresses an issue in the x86 and PowerPC drivers that
> caused the opposite period to be reported in the sample record.
>
It sounds like it would be better if patch 5 comes first otherwise the
feature is introduced as broken.
next prev parent reply other threads:[~2025-01-22 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 12:01 [PATCH v2 0/5] A mechanism for efficient support for per-function metrics mark.barnett
2025-01-06 12:01 ` [PATCH v2 1/5] perf: Allow periodic events to alternate between two sample periods mark.barnett
2025-01-21 13:01 ` Leo Yan
2025-03-07 20:28 ` Mark Barnett
2025-03-10 10:55 ` Leo Yan
2025-01-31 18:44 ` Rob Herring
2025-02-07 19:18 ` Mark Barnett
2025-01-06 12:01 ` [PATCH v2 2/5] perf: Allow adding fixed random jitter to the alternate sampling period mark.barnett
2025-01-06 12:01 ` [PATCH v2 3/5] tools/perf: Modify event parser to support alt-period term mark.barnett
2025-01-06 12:01 ` [PATCH v2 4/5] tools/perf: Modify event parser to support alt-period-jitter term mark.barnett
2025-01-06 12:01 ` [PATCH v2 5/5] perf: Record sample last_period before updating mark.barnett
2025-01-21 17:22 ` Leo Yan
2025-01-22 5:03 ` kernel test robot
2025-01-22 16:47 ` James Clark [this message]
2025-02-07 19:23 ` [PATCH v2 0/5] A mechanism for efficient support for per-function metrics Mark Barnett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca8de228-68c2-4b2c-bb58-30f275afc49e@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben.gainey@arm.com \
--cc=deepak.surti@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.barnett@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).