linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>,
	Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	"Namhyung Kim" <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Felix Fietkau <nbd@nbd.name>,
	Qi Liu <liuqi115@huawei.com>, Like Xu <likexu@tencent.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>,
	"Nick Forrington" <nick.forrington@arm.com>,
	Kajol Jain <kjain@linux.ibm.com>,
	"James Clark" <james.clark@arm.com>,
	Andrew Kilroy <andrew.kilroy@arm.com>,
	"Paul A . Clarke" <pc@us.ibm.com>, Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	<ananth.narayan@amd.com>, <ravi.bangoria@amd.com>,
	<santosh.shukla@amd.com>, <sandipan.das@amd.com>,
	Caleb Biggers <caleb.biggers@intel.com>,
	Perry Taylor <perry.taylor@intel.com>,
	Kshipra Bopardikar <kshipra.bopardikar@intel.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v5 2/4] perf jevents: Add python converter script
Date: Fri, 17 Jun 2022 15:39:28 +0100	[thread overview]
Message-ID: <cb61ea57-ea48-ccd7-fa3f-6e46f196de1e@huawei.com> (raw)
In-Reply-To: <CAP-5=fUZbi2359+jgMx8MNjT0aEt1Ai0aBzA4kc+iKphpJWwCg@mail.gmail.com>

On 17/06/2022 14:33, Ian Rogers wrote:
>> ...                       libzstd: [ on  ]
>> ...        disassembler-four-args: [ on  ]
>> ...         python-dev-is-python3: [ off ]
>>
> Agreed on cleaning up the python Makefile logic. I'd rather do it out
> of these patches.
IMHO I know it's painful to get right but we should have it shouted that 
python is not properly configured and jevents won't get compiled 
(properly) - the message "Python interpreter too old (older than 3.6) 
disabling jevent generation" is too quiet.

Thanks!

  parent reply	other threads:[~2022-06-17 14:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  4:48 [PATCH v5 0/4] Rewrite jevents program in python Ian Rogers
2022-06-16  4:48 ` [PATCH v5 1/4] perf python: Prefer python3 Ian Rogers
2022-06-16  4:48 ` [PATCH v5 2/4] perf jevents: Add python converter script Ian Rogers
2022-06-17  0:03   ` Xing Zhengjun
2022-06-17  1:26     ` Ian Rogers
2022-06-17  1:52       ` Xing Zhengjun
2022-06-17  2:40         ` Ian Rogers
2022-06-17  6:51           ` Xing Zhengjun
2022-06-17 13:33             ` Ian Rogers
2022-06-17 14:02               ` Xing Zhengjun
2022-06-17 14:27                 ` Ian Rogers
2022-06-17 14:39               ` John Garry [this message]
2022-06-16  4:48 ` [PATCH v5 3/4] perf jevents: Switch build to use jevents.py Ian Rogers
2022-06-16  4:48 ` [PATCH v5 4/4] perf jevents: Remove jevents.c Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb61ea57-ea48-ccd7-fa3f-6e46f196de1e@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=andrew.kilroy@arm.com \
    --cc=caleb.biggers@intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=kshipra.bopardikar@intel.com \
    --cc=likexu@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liuqi115@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nbd@nbd.name \
    --cc=nick.forrington@arm.com \
    --cc=pc@us.ibm.com \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    --cc=santosh.shukla@amd.com \
    --cc=will@kernel.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).