From: John Garry <john.g.garry@oracle.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf vendor events arm64: Add AmpereOne core pmu events
Date: Thu, 22 Jun 2023 11:11:12 +0100 [thread overview]
Message-ID: <cd12d1ee-cc40-3d6c-3e7c-72723b548786@oracle.com> (raw)
In-Reply-To: <e8ad583-9650-2ad5-5447-a95ac9fb686a@os.amperecomputing.com>
On 22/06/2023 04:27, Ilkka Koskinen wrote:
>>>
>>> + "ArchStdEvent": "L1D_CACHE_LMISS_RD"
>>> + },
>>> + {
>>> + "ArchStdEvent": "L1D_CACHE_LMISS"
>>
>> L1D_CACHE_LMISS is not defined anywhere.
>
>
> Good catch! I must have thought the python script would at least print a
> warning of missing event as I compared the build logs with and without
> the patch. I can prepare a fix for this and submit with another couple
> of patches. I'm hoping to be able to do that by the beginning of next week.
Hi Ilkka,
Previously the generation of pmu-events.c would fail for a failed event
fixup, like what we have here. So were you going to re-introduce this
feature to fail the generation of pmu-events.c for this? It was not
clear to me which patches you were going to prepare.
Thanks,
John
next prev parent reply other threads:[~2023-06-22 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 22:32 [PATCH] perf vendor events arm64: Add AmpereOne core pmu events Ilkka Koskinen
2023-04-29 21:13 ` Ian Rogers
2023-05-01 12:20 ` John Garry
2023-05-15 21:36 ` Arnaldo Carvalho de Melo
2023-06-21 17:10 ` Dave Kleikamp
2023-06-22 3:27 ` Ilkka Koskinen
2023-06-22 10:11 ` John Garry [this message]
2023-06-22 14:03 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd12d1ee-cc40-3d6c-3e7c-72723b548786@oracle.com \
--to=john.g.garry@oracle.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dave.kleikamp@oracle.com \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).