From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BF0C43334 for ; Wed, 8 Jun 2022 15:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244436AbiFHPvZ (ORCPT ); Wed, 8 Jun 2022 11:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbiFHPvX (ORCPT ); Wed, 8 Jun 2022 11:51:23 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E12FB7DF7; Wed, 8 Jun 2022 08:51:20 -0700 (PDT) Received: from fraeml706-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LJBSc3wMMz67mgD; Wed, 8 Jun 2022 23:47:44 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml706-chm.china.huawei.com (10.206.15.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Wed, 8 Jun 2022 17:51:16 +0200 Received: from [10.47.90.54] (10.47.90.54) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 8 Jun 2022 16:51:15 +0100 Message-ID: Date: Wed, 8 Jun 2022 16:51:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3 3/4] RISC-V: Added generic pmu-events mapfile To: Nikita Shubin CC: Genevieve Chan , =?UTF-8?B?Sm/Do28gTcOhcmlvIERvbWluZ29z?= , Nikita Shubin , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , "Namhyung Kim" , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , , , , Atish Patra References: <20220607131648.29439-1-nikita.shubin@maquefel.me> <20220607131648.29439-4-nikita.shubin@maquefel.me> <9e981523-6032-fd24-08f9-0ef771cd1c2e@huawei.com> <20220608174107.7b94e545@redslave.neermore.group> From: John Garry In-Reply-To: <20220608174107.7b94e545@redslave.neermore.group> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.90.54] X-ClientProxiedBy: lhreml744-chm.china.huawei.com (10.201.108.194) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 08/06/2022 15:41, Nikita Shubin wrote: >>> mat: >>> +# MIDR,Version,JSON/file/pathname,Type >>> +# >>> +# where >>> +# MIDR Processor version >> ARM, no? I'm just saying that MIDR is for ARM, so please ensure that this term is correct for riscv > I've messed with --cc-cmd badly and didn't include every one in cover > letter, sorry for that, attaching link to cover letter: > > https://lore.kernel.org/all/20220607131648.29439-1-nikita.shubin@maquefel.me/ > > They are ARM inspired indeed. > > >>> +# Variant[23:20] and Revision [3:0] should be zero. >>> +# Version could be used to track version of JSON file >>> +# but currently unused. >>> +# JSON/file/pathname is the path to JSON file, relative >>> +# to tools/perf/pmu-events/arch/riscv/. >>> +# Type is core, uncore etc >>> +# >>> +# >>> +#Family-model,Version,Filename,EventType >>> diff --git a/tools/perf/pmu-events/arch/riscv/riscv-generic.json >>> b/tools/perf/pmu-events/arch/riscv/riscv-generic.json new file mode >>> 100644 index 000000000000..013e50efad99 >>> --- /dev/null >>> +++ b/tools/perf/pmu-events/arch/riscv/riscv-generic.json >> where or how are these referenced? > Currently they are not referenced in this version of series at all, ok, right, so a general kernel policy is not to include code which is not referenced. > their purpose is to be used like "ArchStdEvent". > > Through any RISCV implementation should have at least these 3 events. Thanks, John