From: Steve Clevenger <scclevenger@os.amperecomputing.com> To: leo.yan@arm.com, james.clark@linaro.org, mike.leach@linaro.org Cc: suzuki.poulose@arm.com, ilkka@os.amperecomputing.com, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH V9 0/2] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset Date: Fri, 11 Oct 2024 11:17:10 -0600 [thread overview] Message-ID: <cover.1728599785.git.scclevenger@os.amperecomputing.com> (raw) In-Reply-To: <cover.1728599785.git.scclevenger@os.amperecomputing.com> Changes in V9: - Removed V8 patch files 1/4 and 2/4. - Modified set_sym_in_dict (trace-event-python.c) to add map_pgoff in dictionary as-is without regard to MAPPING_IDENTITY. This patch file is now patch 2/2. Changes in V8: - in arm-cs-trace-disasm.py, ensure map_pgoff is not converted to string. - Remove map_pgoff integer conversion in dso not found print message. Changes in V7: - In arm-cs-trace-disasm.py, fix print message core dump resulting from mixed type arithmetic. - Modify CS_ETM_TRACE_ON filter to filter zero start_addr. The CS_ETM_TRACE_ON message is changed to print only in verbose mode. - Removed verbose mode only notification for start_addr/stop_addr outside of dso address range. Changes in V6: - In arm-cs-trace-disasm.py, zero map_pgoff for kernel files. Add map_pgoff to start/end address for dso not found message. - Added "Reviewed-by" trailer for patches 1-3 previously reviewed by Leo Yan in V4 and V5. Changes in V5: - In symbol-elf.c, branch to exit_close label if open file. - In trace_event_python.c, correct indentation. set_sym_in_dict call parameter "map_pgoff" renamed as "addr_map_pgoff" to match local naming. Changes in V4: - In trace-event-python.c, fixed perf-tools-next merge problem. Changes in V3: - Rebased to linux-perf-tools branch. - Squash symbol-elf.c and symbol.h into same commit. - In map.c, merge dso__is_pie() call into existing if statement. - In arm-cs-trace-disasm.py, remove debug artifacts. Changes in V2: - In dso__is_pie() (symbol-elf.c), Decrease indentation, add null pointer checks per Leo Yan review. - Updated mailing list distribution. Steve Clevenger (2): Add map_pgoff to python dictionary Adjust objdump start/end address per map_pgoff parameter tools/perf/scripts/python/arm-cs-trace-disasm.py | 16 +++++++++++----- .../util/scripting-engines/trace-event-python.c | 9 ++++++--- 2 files changed, 17 insertions(+), 8 deletions(-) -- 2.44.0
WARNING: multiple messages have this Message-ID (diff)
From: Steve Clevenger <scclevenger@os.amperecomputing.com> To: leo.yan@arm.com, namhyung@kernel.org, james.clark@linaro.org, mike.leach@linaro.org Cc: suzuki.poulose@arm.com, ilkka@os.amperecomputing.com, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH V10 RESEND 0/2] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset Date: Wed, 6 Nov 2024 16:51:11 -0700 [thread overview] Message-ID: <cover.1728599785.git.scclevenger@os.amperecomputing.com> (raw) Message-ID: <20241106235111.m61bjvC40QRhC6vS6dSIk-mW8FPShm9jGpKzZQfiBYs@z> (raw) In-Reply-To: <cover.1728599785.git.scclevenger@os.amperecomputing.com> Changes in V10: - Removed errant space in patch file 0002. Passed 'git apply --check' at perf-tools-next, 6.11.0-rc6. - Added back missing prefixes. Changes in V9: - Removed V8 patch files 1/4 and 2/4. - Modified set_sym_in_dict (trace-event-python.c) to add map_pgoff in dictionary as-is without regard to MAPPING_IDENTITY. This patch file is now patch 2/2. Changes in V8: - in arm-cs-trace-disasm.py, ensure map_pgoff is not converted to string. - Remove map_pgoff integer conversion in dso not found print message. Changes in V7: - In arm-cs-trace-disasm.py, fix print message core dump resulting from mixed type arithmetic. - Modify CS_ETM_TRACE_ON filter to filter zero start_addr. The CS_ETM_TRACE_ON message is changed to print only in verbose mode. - Removed verbose mode only notification for start_addr/stop_addr outside of dso address range. Changes in V6: - In arm-cs-trace-disasm.py, zero map_pgoff for kernel files. Add map_pgoff to start/end address for dso not found message. - Added "Reviewed-by" trailer for patches 1-3 previously reviewed by Leo Yan in V4 and V5. Changes in V5: - In symbol-elf.c, branch to exit_close label if open file. - In trace_event_python.c, correct indentation. set_sym_in_dict call parameter "map_pgoff" renamed as "addr_map_pgoff" to match local naming. Changes in V4: - In trace-event-python.c, fixed perf-tools-next merge problem. Changes in V3: - Rebased to linux-perf-tools branch. - Squash symbol-elf.c and symbol.h into same commit. - In map.c, merge dso__is_pie() call into existing if statement. - In arm-cs-trace-disasm.py, remove debug artifacts. Changes in V2: - In dso__is_pie() (symbol-elf.c), Decrease indentation, add null pointer checks per Leo Yan review. - Updated mailing list distribution. Steve Clevenger (2): Add map_pgoff to python dictionary Adjust objdump start/end address per map_pgoff parameter tools/perf/scripts/python/arm-cs-trace-disasm.py | 16 +++++++++++----- .../util/scripting-engines/trace-event-python.c | 9 ++++++--- 2 files changed, 17 insertions(+), 8 deletions(-) -- 2.44.0
next parent reply other threads:[~2024-10-11 17:17 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-10-11 17:17 Steve Clevenger [this message] 2024-10-11 17:17 ` [PATCH V9 2/2] Adjust objdump start/end range per map pgoff parameter Steve Clevenger 2024-10-17 11:01 ` Leo Yan 2024-10-17 18:28 ` Namhyung Kim 2024-10-17 21:56 ` Leo Yan 2024-11-06 23:51 ` [PATCH V10 RESEND 2/2] perf script python: " Steve Clevenger 2024-10-11 17:17 ` [PATCH V9 1/2] Add map_pgoff to python dictionary Steve Clevenger 2024-10-17 10:43 ` Leo Yan 2024-10-17 11:03 ` Leo Yan 2024-11-06 23:51 ` [PATCH V10 RESEND 1/2] perf util scripting-engines cs-etm: " Steve Clevenger 2024-11-07 18:51 ` Namhyung Kim 2024-11-08 17:48 ` Steve Clevenger 2024-11-11 19:51 ` Ian Rogers 2024-10-16 17:51 ` [PATCH V9 0/2] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset Namhyung Kim 2024-10-16 18:36 ` Steve Clevenger 2024-11-06 23:51 ` [PATCH V10 RESEND " Steve Clevenger 2024-11-07 14:40 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1728599785.git.scclevenger@os.amperecomputing.com \ --to=scclevenger@os.amperecomputing.com \ --cc=coresight@lists.linaro.org \ --cc=ilkka@os.amperecomputing.com \ --cc=james.clark@linaro.org \ --cc=leo.yan@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mike.leach@linaro.org \ --cc=suzuki.poulose@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).