From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56D6EB64D8 for ; Wed, 14 Jun 2023 14:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245549AbjFNOTU (ORCPT ); Wed, 14 Jun 2023 10:19:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245525AbjFNOTT (ORCPT ); Wed, 14 Jun 2023 10:19:19 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CB43E1BC6; Wed, 14 Jun 2023 07:19:15 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD86B1FB; Wed, 14 Jun 2023 07:19:59 -0700 (PDT) Received: from [192.168.1.3] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE5E43F64C; Wed, 14 Jun 2023 07:19:13 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 15:19:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH] perf tools: Add a place to put kernel config fragments for test runs To: Arnaldo Carvalho de Melo , Masahiro Yamada Cc: linux-perf-users@vger.kernel.org, broonie@kernel.org, Aishwarya.TCV@arm.com, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org References: <20230614140219.2335639-1-james.clark@arm.com> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 14/06/2023 15:13, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 14, 2023 at 03:02:19PM +0100, James Clark escreveu: >> We are currently keeping something like this in our CI because defconfig >> doesn't give full coverage. It's not complete yet, but is a starting >> point as a place to add to when a specific test needs something extra to >> run. >> >> The RFC is for discussion on folder placement and file naming etc. > > Would be interesting to add the Kconfig maintainer to see if they have > an opinion, Masahiro? > > - Arnaldo > One concern I have is that uname -m gives a different result to the ARCH= option for a kernel build (ARCH=arm64). Probably the build time version is more useful to us so maybe that should be the file name. Not sure what the x86 version is or if anyone is actually doing cross x86 builds... >> Signed-off-by: James Clark >> --- >> tools/perf/tests/config-fragments/README | 7 +++++++ >> tools/perf/tests/config-fragments/aarch64 | 1 + >> tools/perf/tests/config-fragments/config | 11 +++++++++++ >> 3 files changed, 19 insertions(+) >> create mode 100644 tools/perf/tests/config-fragments/README >> create mode 100644 tools/perf/tests/config-fragments/aarch64 >> create mode 100644 tools/perf/tests/config-fragments/config >> >> diff --git a/tools/perf/tests/config-fragments/README b/tools/perf/tests/config-fragments/README >> new file mode 100644 >> index 000000000000..e816cfb1b96d >> --- /dev/null >> +++ b/tools/perf/tests/config-fragments/README >> @@ -0,0 +1,7 @@ >> +This folder is for kernel config fragments that can be merged with >> +defconfig to give full test coverage of a perf test run. This is only >> +an optimistic set as some features require hardware support in order to >> +pass and not skip. >> + >> +'config' is shared across all platforms, and for arch specific files, >> +the file name should match that returned by 'uname -m'. >> diff --git a/tools/perf/tests/config-fragments/aarch64 b/tools/perf/tests/config-fragments/aarch64 >> new file mode 100644 >> index 000000000000..64c4ab17cd58 >> --- /dev/null >> +++ b/tools/perf/tests/config-fragments/aarch64 >> @@ -0,0 +1 @@ >> +CONFIG_CORESIGHT_SOURCE_ETM4X=y >> diff --git a/tools/perf/tests/config-fragments/config b/tools/perf/tests/config-fragments/config >> new file mode 100644 >> index 000000000000..c340b3195fca >> --- /dev/null >> +++ b/tools/perf/tests/config-fragments/config >> @@ -0,0 +1,11 @@ >> +CONFIG_TRACEPOINTS=y >> +CONFIG_STACKTRACE=y >> +CONFIG_NOP_TRACER=y >> +CONFIG_RING_BUFFER=y >> +CONFIG_EVENT_TRACING=y >> +CONFIG_CONTEXT_SWITCH_TRACER=y >> +CONFIG_TRACING=y >> +CONFIG_GENERIC_TRACER=y >> +CONFIG_FTRACE=y >> +CONFIG_FTRACE_SYSCALLS=y >> +CONFIG_BRANCH_PROFILE_NONE=y >> -- >> 2.34.1 >> >