linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Jing Zhang <renyu.zj@linux.alibaba.com>, Ian Rogers <irogers@google.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>,
	Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Andrew Kilroy <andrew.kilroy@arm.com>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Zhuo Song <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH v7 0/9] Add metrics for neoverse-n2-v2
Date: Fri, 13 Jan 2023 09:59:08 +0000	[thread overview]
Message-ID: <d33086a5-233f-f591-c9da-5f1a2e8aaf54@oracle.com> (raw)
In-Reply-To: <1673601740-122788-1-git-send-email-renyu.zj@linux.alibaba.com>

On 13/01/2023 09:22, Jing Zhang wrote:
> Changes since v6:
> - Split patch #1 into 3 smaller patches as suggested by Ian.
> - Change perf_pmu__get_slots into perf_pmu__cpu_slots_per_cycle,
>    per John's suggestion;
> - Return NAN instead of 0 in perf_pmu__cpu_slots_per_cycle weak
>    function, per John's suggestion;
> - Factor out pmu_core__find_same function, per John's suggestion.
> - Link:https://urldefense.com/v3/__https://lore.kernel.org/all/1673017529-1429208-1-git-send-email-renyu.zj@linux.alibaba.com/__;!!ACWV5N9M2RV99hQ!LhBq67uDCOsz1k7ZF4aQPHF0Bp8FsMr-ZNgCnBSUKF4qJTFODfnkId7lw_NXqB4qZUCpu-jbY8z8LTckoqFGz2Q8bA$  

This looks fine. But for this code:

On 13/01/2023 09:22, Jing Zhang wrote:
 > +double perf_pmu__cpu_slots_per_cycle(void)
 > +{
 > +	char path[PATH_MAX];
 > +	unsigned long long slots = 0;

I would prefer if this returned NAN (and not 0) for when we can't find a 
pmu or the value from ./caps/slots is zero, but I am not going to get 
too hung up on that.

For series:

Reviewed-by: John Garry <john.g.garry@oracle.com>


  parent reply	other threads:[~2023-01-13 10:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  9:22 [PATCH v7 0/9] Add metrics for neoverse-n2-v2 Jing Zhang
2023-01-13  9:22 ` [PATCH v7 1/9] perf pmu: Add #slots literal support for arm64 Jing Zhang
2023-01-13  9:29   ` Jing Zhang
2023-01-14 22:15   ` Ian Rogers
2023-01-16  2:58     ` Jing Zhang
2023-01-16  5:59       ` Ian Rogers
2023-01-16 11:27         ` Jing Zhang
2023-01-13  9:22 ` [PATCH v7 2/9] perf jevent: Add general metrics support Jing Zhang
2023-01-14 22:39   ` Ian Rogers
2023-01-13  9:22 ` [PATCH v7 3/9] perf vendor events arm64: Add common topdown L1 metrics Jing Zhang
2023-01-13  9:22 ` [PATCH v7 4/9] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2-v2 Jing Zhang
2023-01-13  9:22 ` [PATCH v7 5/9] perf vendor events arm64: Add TLB " Jing Zhang
2023-01-13  9:22 ` [PATCH v7 6/9] perf vendor events arm64: Add cache " Jing Zhang
2023-01-13  9:22 ` [PATCH v7 7/9] perf vendor events arm64: Add branch " Jing Zhang
2023-01-13  9:22 ` [PATCH v7 8/9] perf vendor events arm64: Add PE utilization " Jing Zhang
2023-01-13  9:22 ` [PATCH v7 9/9] perf vendor events arm64: Add instruction mix " Jing Zhang
2023-01-13  9:59 ` John Garry [this message]
2023-01-13 16:32   ` [PATCH v7 0/9] Add " Jing Zhang
2023-01-14 22:40     ` Ian Rogers
2023-01-16  2:59       ` Jing Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d33086a5-233f-f591-c9da-5f1a2e8aaf54@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andrew.kilroy@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=zhengjun.xing@linux.intel.com \
    --cc=zhuo.song@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).