From: Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: brueckner@linux.vnet.ibm.com, zvonko.kosic@de.ibm.com,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/2] perf record: wrong size in perf_record_mmap for last kernel module
Date: Tue, 8 Aug 2017 09:16:42 +0200 [thread overview]
Message-ID: <d3eacb65-01ce-92b6-eff9-9c2ce54019ad@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170807160549.GT12201@kernel.org>
On 08/07/2017 06:05 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 07, 2017 at 09:26:14AM +0200, Thomas-Mich Richter escreveu:
>> On 08/04/2017 07:06 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, Aug 03, 2017 at 11:41:02AM +0200, Thomas-Mich Richter escreveu:
>>>> The idea for the roundup to page size is the assumption that the kernel
>>>> allocates full pages for memory to load modules. The size filed in the /proc/modules
>>>> output refers to the module size in bytes.
>
>>>> If this is wrong we can omit the roundup.
>
>>> Its not wrong, just looks unnecessary, a distraction, I'll remove it, ok?
>
>> Sure go ahead.
>
> Thanks, applied.
>
> - Arnaldo
Thanks for picking this one. Out of curiosity, why didn't you pick the first
part of the patch set:
[PATCH 1/2] perf report fix module symbol adjustment for s390x
Anything wrong with it? Should I repost it?
Thanks
--
Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2017-08-08 7:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 14:35 [PATCH 1/2] perf report fix module symbol adjustment for s390x Thomas Richter
2017-07-24 14:35 ` [PATCH 2/2] perf record: wrong size in perf_record_mmap for last kernel module Thomas Richter
2017-07-24 18:20 ` Arnaldo Carvalho de Melo
2017-07-25 8:45 ` Thomas-Mich Richter
2017-08-02 18:50 ` Arnaldo Carvalho de Melo
2017-08-03 9:41 ` Thomas-Mich Richter
2017-08-04 17:06 ` Arnaldo Carvalho de Melo
2017-08-07 7:26 ` Thomas-Mich Richter
2017-08-07 16:05 ` Arnaldo Carvalho de Melo
2017-08-08 7:16 ` Thomas-Mich Richter [this message]
2017-07-25 6:58 ` Namhyung Kim
2017-07-25 8:26 ` Thomas-Mich Richter
2017-07-25 6:14 ` [PATCH 1/2] perf report fix module symbol adjustment for s390x Namhyung Kim
2017-07-25 8:49 ` Thomas-Mich Richter
2017-07-25 10:32 ` Namhyung Kim
2017-07-25 14:20 ` Arnaldo Carvalho de Melo
2017-08-02 11:25 ` Thomas-Mich Richter
2017-08-02 18:42 ` Arnaldo Carvalho de Melo
2017-08-03 9:37 ` Thomas-Mich Richter
2017-08-03 12:45 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3eacb65-01ce-92b6-eff9-9c2ce54019ad@linux.vnet.ibm.com \
--to=tmricht@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=zvonko.kosic@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).