From: Ravi Bangoria <ravi.bangoria@amd.com>
To: peterz@infradead.org, Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, mark.rutland@arm.com, jolsa@redhat.com,
namhyung@kernel.org, eranian@google.com,
kan.liang@linux.intel.com, bp@alien8.de, x86@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
sandipan.das@amd.com, ananth.narayan@amd.com,
santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH] perf/amd/ibs: Make IBS a core pmu
Date: Wed, 16 Nov 2022 11:15:54 +0530 [thread overview]
Message-ID: <d839086b-826d-3642-5be2-a62714457b62@amd.com> (raw)
In-Reply-To: <CAP-5=fXq-YNKogH4DYQuf7rz8TZhu8=QnEsA2pvzj6YS_DQO7g@mail.gmail.com>
On 15-Nov-22 10:37 PM, Ian Rogers wrote:
> On Tue, Nov 15, 2022 at 1:39 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>
>> So far, only one pmu was allowed to be registered as core pmu and thus
>> IBS pmus were being registered as uncore. However, with the event context
>> rewrite, that limitation no longer exists and thus IBS pmus can also be
>> registered as core pmu. This makes IBS much more usable, for ex, user
>> will be able to do per-process precise monitoring on AMD:
>>
>> Before patch:
>> $ sudo perf record -e cycles:pp ls
>> Error:
>> Invalid event (cycles:pp) in per-thread mode, enable system wide with '-a'
>>
>> After patch:
>> $ sudo perf record -e cycles:pp ls
>> [ perf record: Woken up 1 times to write data ]
>> [ perf record: Captured and wrote 0.017 MB perf.data (33 samples) ]
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>
> Acked-by: Ian Rogers <irogers@google.com>
>
> This is awesome!
> Ian
Thanks Ian.
Peter, can we push this along with rewrite patch?
Thanks,
Ravi
next prev parent reply other threads:[~2022-11-16 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:39 [PATCH] perf/amd/ibs: Make IBS a core pmu Ravi Bangoria
2022-11-15 17:07 ` Ian Rogers
2022-11-16 5:45 ` Ravi Bangoria [this message]
2022-11-22 8:13 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d839086b-826d-3642-5be2-a62714457b62@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox