From: kajoljain <kjain@linux.ibm.com>
To: John Garry <john.garry@huawei.com>, acme@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, pc@us.ibm.com,
jolsa@redhat.com, namhyung@kernel.org, ak@linux.intel.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com
Subject: Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.
Date: Fri, 4 Sep 2020 13:59:22 +0530 [thread overview]
Message-ID: <d8f98c89-0a11-3844-01f2-3562ff2bdea9@linux.ibm.com> (raw)
In-Reply-To: <34566244-88ba-562b-71cf-414a0ba307f4@huawei.com>
On 9/2/20 10:35 PM, John Garry wrote:
> On 02/09/2020 17:04, Kajol Jain wrote:
>> This patch adds new structure called 'json_event' inside jevents.h
>> file to improve the callback prototype inside jevent files.
>> Initially, whenever user want to add new field, they need to update
>> in all function callback which make it more and more complex with
>> increased number of parmeters.
>> With this change, we just need to add it in new structure 'json_event'.
>>
>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>> Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
> Reviewed-by: John Garry <john.garry@huawei.com>
>
>> +static int json_events
>
> Adding 'static' should have really been in the previous patch ...
Hi John,
Right, Thanks for pointing it, I will update.
Thanks,
Kajol Jain
>
next prev parent reply other threads:[~2020-09-04 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:04 [PATCH v7 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Kajol Jain
2020-09-02 16:04 ` [PATCH v7 1/5] perf/jevents: Remove jevents.h file Kajol Jain
2020-09-02 17:00 ` John Garry
2020-09-02 16:04 ` [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields Kajol Jain
2020-09-02 17:05 ` John Garry
2020-09-04 8:29 ` kajoljain [this message]
2020-09-03 14:54 ` Namhyung Kim
2020-09-04 8:30 ` kajoljain
2020-09-02 16:04 ` [PATCH v7 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-09-02 16:04 ` [PATCH v7 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-09-02 16:04 ` [PATCH v7 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f98c89-0a11-3844-01f2-3562ff2bdea9@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).