linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kajoljain <kjain@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com,
	atrajeev@linux.vnet.ibm.com, disgoel@linux.ibm.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document processor_bus_topology sysfs interface file
Date: Fri, 14 Jul 2023 12:32:02 +0530	[thread overview]
Message-ID: <d91cee25-19d6-2eaa-1ad3-94718fa253cb@linux.ibm.com> (raw)
In-Reply-To: <4418618a-ac75-f824-ec6d-984421dd5c6b@infradead.org>











Thanks Randy for the review comments, I will do these updates
for all documentation patches in my next version of patchset.

Thanks,
Kajol Jain

On 7/12/23 02:22, Randy Dunlap wrote:
> Hi--
> 
> On 7/10/23 02:27, Kajol Jain wrote:
>> Add details of the new hv-gpci interface file called
>> "processor_bus_topology" in the ABI documentation.
>>
>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>> ---
>>  .../sysfs-bus-event_source-devices-hv_gpci    | 32 +++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_gpci b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_gpci
>> index 12e2bf92783f..2eeeab9a20fa 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_gpci
>> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_gpci
>> @@ -80,3 +80,35 @@ Contact:	Linux on PowerPC Developer List <linuxppc-dev@lists.ozlabs.org>
>>  Description:	read only
>>  		This sysfs file exposes the cpumask which is designated to make
>>  		HCALLs to retrieve hv-gpci pmu event counter data.
>> +
>> +What:		/sys/devices/hv_gpci/interface/processor_bus_topology
>> +Date:		July 2023
>> +Contact:	Linux on PowerPC Developer List <linuxppc-dev@lists.ozlabs.org>
>> +Description:	admin read only
>> +		This sysfs file exposes the system topology information by making HCALL
>> +		H_GET_PERF_COUNTER_INFO. The HCALL is made with counter request value
>> +		PROCESSOR_BUS_TOPOLOGY(0xD0).
>> +
>> +		* This sysfs file will be created only for power10 and above platforms.
>> +
>> +		* User needs root privileges to read data from this sysfs file.
>> +
>> +		* This sysfs file will be created, only when the HCALL returns "H_SUCESS",
> 
> 		                                                                H_SUCCESS
> 
>> +		  "H_AUTHORITY" and "H_PARAMETER" as the return type.
> 
> 		            s/and/or/
> 
>> +
>> +		  HCALL with return error type "H_AUTHORITY", can be resolved during
> 
> 		                             Drop the comma ^
> 
>> +		  runtime by setting "Enable Performance Information Collection" option.
>> +
>> +		* The end user reading this sysfs file must decode the content as per
>> +		  underlying platform/firmware.
>> +
>> +		Possible error codes while reading this sysfs file:
>> +
>> +		* "-EPERM" : Partition is not permitted to retrieve performance information,
>> +			    required to set "Enable Performance Information Collection" option.
>> +
>> +		* "-EIO" : Can't retrieve system information because of invalid buffer length/invalid address
>> +			   or because of some hardware error. Refer getPerfCountInfo documentation for
> 
> 			                                      Refer to
> 
>> +			   more information.
>> +
>> +		* "-EFBIG" : System information exceeds PAGE_SIZE.
> 

  reply	other threads:[~2023-07-14  7:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10  9:27 [PATCH v2 00/10] Add sysfs interface files to hv_gpci device to expose system information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 01/10] powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show processor bus topology information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 02/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document processor_bus_topology sysfs interface file Kajol Jain
2023-07-11 20:52   ` Randy Dunlap
2023-07-14  7:02     ` kajoljain [this message]
2023-07-10  9:27 ` [PATCH v2 03/10] powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show processor config information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 04/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document processor_config sysfs interface file Kajol Jain
2023-07-11 20:54   ` Randy Dunlap
2023-07-10  9:27 ` [PATCH v2 05/10] powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show affinity domain via virtual processor information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 06/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document affinity_domain_via_virtual_processor sysfs interface file Kajol Jain
2023-07-11 20:56   ` Randy Dunlap
2023-07-10  9:27 ` [PATCH v2 07/10] powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show affinity domain via domain information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 08/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document affinity_domain_via_domain sysfs interface file Kajol Jain
2023-07-11 20:57   ` Randy Dunlap
2023-07-10  9:27 ` [PATCH v2 09/10] powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show affinity domain via partition information Kajol Jain
2023-07-10  9:27 ` [PATCH v2 10/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document affinity_domain_via_partition sysfs interface file Kajol Jain
2023-07-11 20:58   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d91cee25-19d6-2eaa-1ad3-94718fa253cb@linux.ibm.com \
    --to=kjain@linux.ibm.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=disgoel@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).