From: John Garry <john.garry@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>,
<irogers@google.com>, <kan.liang@linux.intel.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf pmu: Fix event list for uncore PMUs
Date: Wed, 22 Dec 2021 13:08:20 +0000 [thread overview]
Message-ID: <d987a1a9-3c3f-9efb-24c7-22e18d8d63e4@huawei.com> (raw)
In-Reply-To: <YcI9twHCIiFyUDOu@kernel.org>
On 21/12/2021 20:48, Arnaldo Carvalho de Melo wrote:
>> Now thinking a bit more I am not confident that this patch is a full fix.
>>
>> arm have heterogeneous CPU systems as well - which are not "hybrid" - and I
>> need to ensure that aliasing is still working properly there, as I think
>> that this following check would stop removing duplicates there:
>>
>> + /* uncore PMUs */
>> + if (!alias_a->is_cpu && !alias_b->is_cpu)
>> + return true;
>> + return false;
> I was about to process this, do you think its better to revert the
> original patch while this gets fixed?
I think that the v2 should now be ok.
@jirka, can you kindly help to check that?
BTW, my patch is based on v5.16-rc5 . I assumed that I would need to be
based on acme/perf/urgent, but that seems to be based on 5.15
Thanks,
John
prev parent reply other threads:[~2021-12-22 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 15:53 [PATCH] perf pmu: Fix event list for uncore PMUs John Garry
2021-12-18 1:47 ` Arnaldo Carvalho de Melo
2021-12-20 8:38 ` John Garry
2021-12-20 16:34 ` Liang, Kan
2021-12-21 6:59 ` Xing Zhengjun
2021-12-21 7:58 ` Jiri Olsa
2021-12-21 9:10 ` John Garry
2021-12-21 9:35 ` Jiri Olsa
2021-12-21 10:14 ` John Garry
2021-12-21 20:48 ` Arnaldo Carvalho de Melo
2021-12-22 13:08 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d987a1a9-3c3f-9efb-24c7-22e18d8d63e4@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox