From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.itxnorge.no (itx-kvm-14.itxnorge.no [91.189.121.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406DC39F190 for ; Tue, 22 Sep 2026 14:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.189.121.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790087824; cv=none; b=GuBAc2sCfEIhvrsV10IYvP9prHS1WApqTEux0w/gC7cCvaVsHv4utFO0xcXBSCcvBymFLko7rT+GhdesaOAlxX2GI+rMh6R4xCgX3RksktsCmgsDFlTtWxT3LN0FRdptbEo2uxbDX47UvKJ07vuikRVI88VhrysS8Ygw/5H7ZV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790087824; c=relaxed/simple; bh=gKE+IC+RlKzgX1ZxfQsURndg+yzO2TivVRk7zoVur54=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WMiWOVhIGsfyUVAdYYkHjGaVKdQYqi4kDexAXsgj0Q8gZKDHPuJ76y0IXQP/sXD1t83JUYFC+qGblr/YuXrPs4VxEsk952t9jx8i6285L52MjRLGZpQb8s4eo6pTLvbUSxWWvVbQ82QcptmqwKNbsSulFjZbCniA7HOCvQDVS5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=itx.no; spf=pass smtp.mailfrom=itx.no; dkim=pass (1024-bit key) header.d=itx.no header.i=@itx.no header.b=K6zOZB3a; arc=none smtp.client-ip=91.189.121.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=itx.no Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=itx.no Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=itx.no header.i=@itx.no header.b="K6zOZB3a" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itx.no; s=mx.itx.no; t=1790087819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKE+IC+RlKzgX1ZxfQsURndg+yzO2TivVRk7zoVur54=; b=K6zOZB3a0RdDFWLIaNhNfYyk8ISYcPACJY6DpQakDlAEEWkEVT9Cb1u2WvlM54ETVHzh1H 6/010ac/Kjpom87v48zwV1LpyUoPWNbWnQgiJcsjn3wVeVNDYoDZrA/VGZED6655CMc865 AnVrGD0hosnugEXukuGFsm6+frumeHE= Subject: Re: [RFC PATCH 2/2] sparc64: Support PERF_SAMPLE_REGS_USER and PERF_SAMPLE_STACK_USER From: Stian Halseth To: sashiko-reviews@lists.linux.dev Cc: linux-perf-users@vger.kernel.org Date: Tue, 22 Sep 2026 16:36:58 +0200 In-Reply-To: <20260922141826.CC3081F00898@smtp.kernel.org> References: <20260922135653.1622301-1-stian@itx.no> <20260922135653.1622301-3-stian@itx.no> <20260922141826.CC3081F00898@smtp.kernel.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fhpVbAZQ2zd0TP6YUJvB" Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-fhpVbAZQ2zd0TP6YUJvB Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable On Tue, 2026-09-22 at 14:18 +0000, sashiko-bot@kernel.org wrote: >=20 > [Severity: Medium] > Since HAVE_PERF_USER_STACK_DUMP is selected in Kconfig, shouldn't > there also > be an override for perf_user_stack_pointer() here to account for > STACK_BIAS > on 64-bit tasks? Nothing to override. perf_user_stack_pointer() is a plain macro in kernel/events/internal.h.=A0Also, I don't think we should, as long as every consumer takes the sampled stack pointer register as the base. sparc-aware consumers add the 2047 when they interpret the stack. Like for example ptrace data. It would make sparc the only arch where dump doesn't begin at the SP register. >=20 > [Severity: Medium] > Will this unconditionally truncate 64-bit kernel registers for 32-bit > compat > tasks? Yes,=A0will correct that. Next version truncates only when user_mode(regs), the same test arm64 makes with compat_user_mode(). --=-fhpVbAZQ2zd0TP6YUJvB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTK1ph9OaYoND1R57zoeAEuJe36VgUCarKSigAKCRDoeAEuJe36 Vr+uAQCzOluZSNxYL1lKvGiqZeI3y4wgOg09GOI+pLNXZPSRsQEAzsomT6KoGTuC ne0/7IhSQ11VtyXWEmkiovuhTLmFXA4= =OpX4 -----END PGP SIGNATURE----- --=-fhpVbAZQ2zd0TP6YUJvB--