From: Tony Jones <tonyj@suse.de>
To: Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py
Date: Tue, 5 Mar 2019 07:02:34 -0800 [thread overview]
Message-ID: <dfa719d4-0d9e-ad08-536f-17b3da116b19@suse.de> (raw)
In-Reply-To: <6fe06c75-5f98-4829-e139-af2bfcda24f3@intel.com>
On 3/5/19 2:16 AM, Adrian Hunter wrote:
> On 2/03/19 3:19 AM, Tony Jones wrote:
>> Support both Python2 and Python3 in the intel-pt-events.py script
>>
>> There may be differences in the ordering of output lines due to
>> differences in dictionary ordering etc. However the format within lines
>> should be unchanged.
>>
>> The use of 'from __future__' implies the minimum supported Python2 version
>> is now v2.6
>>
>> Signed-off-by: Tony Jones <tonyj@suse.de>
>> Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>
> One change missed, see below, otherwise:
I tested the patch on a Skylake system but it was not connected to our standard
network so I had to move files manually. It seems I managed to somehow mess up
and not attach the correct patch :(
>> def trace_unhandled(event_name, context, event_fields_dict):
>> print ' '.join(['%s=%s'%(k,str(v))for k,v in sorted(event_fields_dict.items())])
>
> Also above line
You are correct. Apologies. I'll send a revised version.
tony
next prev parent reply other threads:[~2019-03-05 15:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 1:18 [PATCH v2 0/7] perf script python: add Python3 support Tony Jones
2019-03-02 1:18 ` [PATCH v2 1/7] perf script python: remove mixed indentation Tony Jones
2019-03-05 10:39 ` Adrian Hunter
2019-03-06 21:09 ` Arnaldo Carvalho de Melo
2019-03-02 1:18 ` [PATCH v2 2/7] perf script python: add Python3 support to futex-contention.py Tony Jones
2019-03-06 21:11 ` Arnaldo Carvalho de Melo
2019-03-02 1:18 ` [PATCH v2 3/7] perf script python: add Python3 support to check-perf-trace.py Tony Jones
2019-03-06 21:11 ` Arnaldo Carvalho de Melo
2019-03-02 1:19 ` [PATCH v2 4/7] perf script python: add Python3 support to event_analyzing_sample.py Tony Jones
2019-03-06 21:11 ` Arnaldo Carvalho de Melo
2019-03-02 1:19 ` [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py Tony Jones
2019-03-05 10:16 ` Adrian Hunter
2019-03-05 15:02 ` Tony Jones [this message]
2019-03-05 16:10 ` Tony Jones
2019-03-05 16:19 ` Tony Jones
2019-03-06 9:28 ` Adrian Hunter
2019-03-06 21:12 ` Arnaldo Carvalho de Melo
2019-03-02 1:19 ` [PATCH v2 6/7] perf script python: add Python3 support to sql scripts Tony Jones
2019-03-06 9:26 ` Adrian Hunter
2019-03-06 16:32 ` Tony Jones
2019-03-07 18:51 ` Arnaldo Carvalho de Melo
2019-03-08 9:47 ` Adrian Hunter
2019-03-08 14:36 ` Arnaldo Carvalho de Melo
2019-03-02 1:19 ` [PATCH v2 7/7] perf script python: add printdate function to SQL exporters Tony Jones
2019-03-06 21:13 ` Arnaldo Carvalho de Melo
2019-03-08 12:50 ` Adrian Hunter
2019-03-05 9:55 ` [PATCH v2 0/7] perf script python: add Python3 support Adrian Hunter
2019-03-05 14:53 ` Tony Jones
2019-03-05 15:18 ` Tony Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa719d4-0d9e-ad08-536f-17b3da116b19@suse.de \
--to=tonyj@suse.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=s1seetee@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).